Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scaling factor and yt normalization [2301.10972] #383

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pnsuau
Copy link
Contributor

@pnsuau pnsuau commented Mar 16, 2023

Add the scaling factor and the noisy image normalization from https://arxiv.org/pdf/2301.10972.pdf.

New options :

  • --alg_palette_scaling_factor : the scaling factor applied to ground truth image when added to noise at training time
  • --alg_palette_normalize_yt: whether to normalize the noisy image before feeding it to the denoising neural network

Usage :

python3 train.py --alg_palette_scaling_factor 0.3 --alg_palette_normalize_yt

@pnsuau pnsuau requested a review from beniz March 16, 2023 08:42
@pnsuau pnsuau self-assigned this Mar 16, 2023
@pnsuau pnsuau force-pushed the feat_simple_diffusion_scaling branch from 0bbb5a9 to 5623e31 Compare March 16, 2023 08:51
@pnsuau pnsuau marked this pull request as ready for review March 16, 2023 08:51
@beniz
Copy link
Contributor

beniz commented Mar 17, 2023

NameError: name 'y_t' is not defined

@pnsuau pnsuau force-pushed the feat_simple_diffusion_scaling branch from 47dfc92 to d566fe4 Compare March 17, 2023 14:35
@beniz
Copy link
Contributor

beniz commented Mar 24, 2023

Breaks with --G_netG mobile_resnet_attn

  File "/data1/beniz/code/joliGAN/train.py", line 87, in train_gpu
    model = create_model(opt, rank)  # create a model given opt.model and other options
  File "/data1/beniz/code/joliGAN/models/__init__.py", line 84, in create_model
    instance = model(opt, rank)
  File "/data1/beniz/code/joliGAN/models/palette_model.py", line 114, in __init__
    self.netG_A = diffusion_networks.define_G(**vars(opt))
  File "/data1/beniz/code/joliGAN/models/diffusion_networks.py", line 111, in define_G
    denoise_fn = ResnetGenerator_attn_diff(
  File "/data1/beniz/code/joliGAN/models/modules/resnet_architecture/resnet_generator_diff.py", line 198, in __init__
    nn.Sequential(nn.Conv2d(input_nc, ngf, 7, 1, 0), normalization(ngf)),
TypeError: normalization() missing 1 required positional argument: 'norm'

@beniz beniz marked this pull request as draft April 4, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants