Feedback is welcome! I'll start.. Even though the user is led there by a classic cog symbol, I wonder if it would be worth keeping a main "Settings" title at the very top before the first section

Hey @benalleng!

Really nice. Thank you!

Two things from my side:

• If you are okay with it, let's remove the flags from the language dropdown. e.g. French is spoken in many countries, not exclusively in France. Same with English and many other languages. I'd vote for removing them. Just let me know what you think.
• Some translations in fr/translation.json are in English. It's easier to see the progress on Transifex, if this file only contains actually translated keys, e.g. French has 68% translated keys. Missing keys will fallback to English anyway!

Feedback is welcome! I'll start.. Even though the user is led there by a classic cog symbol, I wonder if it would be worth keeping a main "Settings" title at the very top before the first section

My 2 sats: I think both is fine. We can keep it this way for now and if you are not happy with it, add a main header in a follow-up PR, if you so please!

What do you think? Let me know if you want to make the adaptions yourself.
Once done, I think it is ready to be merged. 🚀

• Ok! sounds good to me, as I look at it more I agree that as long as we continue to use the proper script for each language, flags aren't really needed or preferred.
• sorry about the Transifex thing, I didn't realize that was the proper method to go through translations. For the future I'll make sure to help with translations there 😅 I'll also remove the other translations that already fallback to english!

• Ok! sounds good to me, as I look at it more I agree that as long as we continue to use the proper script for each language, flags aren't really needed or preferred.

👍

• sorry about the Transifex thing, I didn't realize that was the proper method to go through translations. For the future I'll make sure to help with translations there sweat_smile I'll also remove the other translations that already fallback to english!

Don't worry!

Two small suggestions (one typo keeping the tests from succeeding, and removing left-over untranslated keys from fr), then we can push it over the finish line. 💪

Awesome! exciting to have my code merged! A question for the future, how do I conduct tests before I submit a pull request so that i can be certain you have less work to complete the merges on your end. Still a pretty new coder and I'm not too familiar with running tests 😅 Thanks for your help in getting it all finished, excited to sink my teeth into more issues moving forward!

Awesome! exciting to have my code merged!

💪

Thanks again for your work. Every little improvement is important in open source development. Your contribution is invaluable for projects like Jam.

A question for the future, how do I conduct tests before I submit a pull request so that i can be certain you have less work to complete the merges on your end. Still a pretty new coder and I'm not too familiar with running tests sweat_smile Thanks for your help in getting it all finished, excited to sink my teeth into more issues moving forward!

Don't worry too much. We can figure it out during review and no code is perfect at first try. You can try running npm test before submitting your work - it's cool that you already adapted the tests in this PR in the first place ;-)

To run all tests (non-interactively) do CI=true npm test.

Fantastic! Thank you for your contribution @benalleng 🙏🧡