Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rescan): enable rescanning chain #833

Closed
theborakompanioni opened this issue Sep 4, 2024 · 2 comments · Fixed by #838
Closed

feat(rescan): enable rescanning chain #833

theborakompanioni opened this issue Sep 4, 2024 · 2 comments · Fixed by #838
Labels
enhancement New feature or request good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience

Comments

@theborakompanioni
Copy link
Collaborator

Rescanning the chain has been an experimental feature and is hidden by default.

Making it available would help non-technical users to not going through the steps outlined in joinmarket-webui/jamdocs#47 and does away the need to use the CLI.

Steps to do:

  • i18n support: translate strings in the page component
  • remove the dev badge
  • Keep "experimental" in the title?
@theborakompanioni theborakompanioni added enhancement New feature or request good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience labels Sep 4, 2024
@theborakompanioni theborakompanioni mentioned this issue Sep 4, 2024
Closed
@nischal-shetty2
Copy link
Contributor

ill create a pr for this feature but

  • Keep "experimental" in the title?

Should i keep this in? @theborakompanioni @editwentyone

@nischal-shetty2 nischal-shetty2 mentioned this issue Sep 7, 2024
Merged
@theborakompanioni
Copy link
Collaborator Author

ill create a pr for this feature but

  • Keep "experimental" in the title?

Should i keep this in? @theborakompanioni @editwentyone

Yes, I think we should keep it for now. It can always be removed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added rescan page translations and removed dev mode tag nischal-shetty2/jam
2 participants
@theborakompanioni @nischal-shetty2