Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unit and visibility toggle on main wallet view #806

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

theborakompanioni
Copy link
Collaborator

Most wallets have the ability to switch the unit of account (BTC or sats) by clicking at the balance.

Before this commit, the balance on the main wallet view has been a visibility toggle only. If a user clicked the balance it either showed the balance in the preferred unit or hid the balance.
e.g. BTC -> hidden -> BTC -> hidden, etc.

After this commit, a click will change the unit of the balance and only with a subsequent click toggles the visibility.
e.g. BTC -> sats -> hidden -> BTC -> sats, etc.

@theborakompanioni theborakompanioni added the UI/UX Issue related to cosmetics, design, or user experience label Aug 4, 2024
@theborakompanioni theborakompanioni self-assigned this Aug 4, 2024
@theborakompanioni theborakompanioni marked this pull request as ready for review August 4, 2024 11:16
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like, thanks

@theborakompanioni theborakompanioni merged commit 09aa113 into devel Aug 6, 2024
@theborakompanioni theborakompanioni deleted the feat/main-unit-switcher branch August 6, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants