Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Improve readablity of balances in light mode on dark backgrounds #770

Closed
theborakompanioni opened this issue May 28, 2024 · 17 comments · Fixed by #822
Closed

ui: Improve readablity of balances in light mode on dark backgrounds #770

theborakompanioni opened this issue May 28, 2024 · 17 comments · Fixed by #822
Labels
good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience

Comments

@theborakompanioni
Copy link
Collaborator

Balances do not look very nice in light mode on dark backgrounds, e.g. in tooltips.
They should be made more readable and easy on the eyes.

Screenshot from 2024-05-28 23-09-32

Originally posted by @barrytra in #766 (comment)

@theborakompanioni theborakompanioni added good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience labels May 28, 2024
@SnehalSrivastava27
Copy link
Contributor

@theborakompanioni is this issue still open ?

@barrytra
Copy link
Contributor

barrytra commented Jul 5, 2024

@SnehalSrivastava27 Yes it is!!

@SnehalSrivastava27
Copy link
Contributor

@barrytra Can I take up this issue

@barrytra
Copy link
Contributor

barrytra commented Jul 7, 2024

Lets discuss it here @SnehalSrivastava27
Can u show me what error do u get on running npm run regtest:rebuild and npm run regtest:up

@SnehalSrivastava27
Copy link
Contributor

This is what I get on npm run regtest:rebuild
image

and This is what I get on npm run regtest:up
image

@SnehalSrivastava27
Copy link
Contributor

I am almost ready with solving the issue but facing problem in running backend

@barrytra
Copy link
Contributor

barrytra commented Jul 8, 2024

Are you inside the cloned Jam directory when you make these commands?

@SnehalSrivastava27
Copy link
Contributor

@barrytra yes

@barrytra
Copy link
Contributor

barrytra commented Jul 8, 2024

@theborakompanioni Can you have a look at the errors?

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Jul 9, 2024

@theborakompanioni Can you have a look at the errors?

@SnehalSrivastava27 The first error is while building a docker image and could be related to network issues, so it might be temporary. Can you re-run the command?

Regarding the second error: Since it seems you are using some version of Windows, I am afraid I cannot reproduce the issue. I would have thought there is some kind of posix subsystem to make it work ("Windows Services for Linux", WSL?) or something.. (but I am not familiar with it and hence unable to help).

So.. if you care about it enough.. use your favourite search engine to search for that or–and this is a personal opinion, please don't get it the wrong way–use a proper operating system for your development work. 😉

@kristapsk
Copy link
Contributor

Regarding the second error: Since it seems you are using some version of Windows, I am afraid I cannot reproduce the issue. I would have thought there is some kind of posix subsystem to make it work ("Windows Services for Linux", WSL?) or something.. (but I am not familiar with it and hence unable to help).

WSL2 is the way to go for Windows nowadays. It allows to run Ubuntu or whatever Linux distro you want under Windows 10/11.

P.S. "Windows Subsystem for Linux" (not "Services"). :)

@SnehalSrivastava27
Copy link
Contributor

SnehalSrivastava27 commented Jul 10, 2024

@theborakompanioni in the first issue I have run the command several times
will try to run few more times

@SnehalSrivastava27
Copy link
Contributor

Hi everyone
I am unable to locally setup the project tried more than 15 times therefore I apologize that I cannot contribute into this issue looking forward to contribute in future when I may face good device

@SnehalSrivastava27 SnehalSrivastava27 removed their assignment Jul 14, 2024
@theborakompanioni
Copy link
Collaborator Author

Hi everyone I am unable to locally setup the project tried more than 15 times therefore I apologize that I cannot contribute into this issue looking forward to contribute in future when I may face good device

Hey @SnehalSrivastava27 that is very unfortunate. I apologize that it is not working for you and that it does not seem to work or still needs effort to run the dev setup on Microsoft Windows™ Operating System.

@0xSaksham
Copy link
Contributor

I'll take a look at this when I'll have time.

@0xSaksham
Copy link
Contributor

Hi everyone I am unable to locally setup the project tried more than 15 times therefore I apologize that I cannot contribute into this issue looking forward to contribute in future when I may face good device

Try dual booting your system with Fedora.

@SnehalSrivastava27
Copy link
Contributor

SnehalSrivastava27 commented Aug 24, 2024

@0xSaksham I have dual booted with Ubuntu and now the project is working smoothly also I have got my one PR merged

Thankyou for helping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants