Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(import): validate mnemonic phrase against BIP39 wordlist #641

Closed
theborakompanioni opened this issue Aug 18, 2023 · 0 comments · Fixed by #739
Closed

feat(import): validate mnemonic phrase against BIP39 wordlist #641

theborakompanioni opened this issue Aug 18, 2023 · 0 comments · Fixed by #739
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Milestone
v0.3.5

Comments

@theborakompanioni
Copy link
Collaborator

Currently, the jm backend will do the validation and fail, if the mnemonic phrase is invalid.
There should also be a visual hint, that the given word is contained in the BIP39 wordlist.

If a some words are not part of the BIP39 wordlist, make the user aware, but still continue the flow!

From: https://www.figma.com/file/kfejZJFlwBywvLEnPEmJo1/JoinMarket-UI?node-id=2850%3A67638
@theborakompanioni theborakompanioni added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels Aug 18, 2023
@theborakompanioni theborakompanioni mentioned this issue Aug 18, 2023
Merged
6 tasks
@editwentyone editwentyone added this to JAM Oct 13, 2023
@zmjohnso zmjohnso mentioned this issue Apr 4, 2024
Merged
@github-project-automation github-project-automation bot moved this to Done ✅ in JAM Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
JAM
Status: Done ✅
Milestone
v0.3.5
Development

Successfully merging a pull request may close this issue.

641 Validate Mnemonic Words on Wallet Import zmjohnso/jam
1 participant
@theborakompanioni