Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Check for existing wallet before importing/creating wallets #636

Closed
theborakompanioni opened this issue Aug 13, 2023 · 1 comment
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@theborakompanioni
Copy link
Collaborator

Expected behavior

A user will be warned early if a wallet name is already taken.

Actual behavior

On the create or import page, if a duplicate wallet name is given, the user is not warned and will error only later in the process (e.g. after providing a mnemonic phrase).

Steps to reproduce the problem

  1. Imit the regtest environment
  2. Try to create or import a wallet names "Satoshi" (which already exists)
  3. Notice that an error occurs when submitting the last step - which could be known earlier

Thanks to @editwentyone for reporting this.

@theborakompanioni
Copy link
Collaborator Author

Resolved in #720. Thank you @zmjohnso 🙏

@github-project-automation github-project-automation bot moved this to Done ✅ in JAM Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

1 participant