Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: add Chinese translation 🇨🇳 (Simplified & Traditional) #628

Merged

Conversation

Overload3910
Copy link
Contributor

@Overload3910 Overload3910 commented Jun 28, 2023

Imported the Chinese translations from Transifex that someone else did, because according to the matrix group, these are already finished.

SCR-20230628-hcw

Imported Chinese Translations from Transifex
@theborakompanioni theborakompanioni added the i18n Issues related to translation and internationalisation (i18n) label Jun 28, 2023
@theborakompanioni theborakompanioni changed the title i18n: add Chinese translation (Simplified & Traditional) i18n: add Chinese translation 🇨🇳 (Simplified & Traditional) Jun 28, 2023
@theborakompanioni
Copy link
Collaborator

There are some build errors as the translation files are not imported correctly. Would you be able to make the necessary changes and verify that it works in your regtest environment?

If I can be of any service, please do not hesitate to ask! 🙏

Fixed import formatting and added missing lines

Removed remnants of the not yet merged German translation that made it into the initial pull request due to an error in branch creation.
@Overload3910
Copy link
Contributor Author

Builds fine for me now. Can you confirm? :)

@Overload3910 Overload3910 marked this pull request as ready for review July 2, 2023 08:51
@theborakompanioni
Copy link
Collaborator

Builds fine for me now. Can you confirm? :)

Yes. Looks great. 🎉

@theborakompanioni theborakompanioni self-requested a review July 3, 2023 10:50
Copy link
Collaborator

@theborakompanioni theborakompanioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'd say we merge this now and wait for user feedback. :rocket

@theborakompanioni theborakompanioni merged commit 550a435 into joinmarket-webui:master Jul 3, 2023
@Overload3910 Overload3910 deleted the chinese-translations branch July 3, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues related to translation and internationalisation (i18n)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants