-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): add italian translation it
🇮🇹
#627
Conversation
it
it
🇮🇹
Maybe @httpiga? edit: I have just a little concern about the translation of "sweep"-related words, which is absolutely awful in Italian 😅 |
Thanks for tagging me! Sure, I'll take a look at this ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the number of comments but once I noticed I needed to start a review instead of writing single comments, it was too late 😅
This is great work, congratulations! 🎉
I left some comments with open discussion and others about typos or wrong placeholders.
As you mentioned, the "Sweep" function translation isn't so nice to read, what about embracing language contamination and keeping it as "Sweep"?
(I'd also like to suggest the same for the "Earn" translation but it's a merely personal preference)
Thank you for your feedback. I've added a couple of comments, but they are just refinements. |
Co-authored-by: Nicola Elia <[email protected]>
Co-authored-by: Nicola Elia <[email protected]>
Co-authored-by: Nicola Elia <[email protected]>
Co-authored-by: Nicola Elia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked again all my suggestions but I trust, don't verify that you corrected all the flagged errors. Thank you for your contribution! 😄
Co-authored-by: Nicola Elia <[email protected]>
Thank you guys! I applied all the suggestions marked with ":+1:" -> The discussions still open have no change suggestions. If you want to make changes, would you add a change suggestions so I can apply it? |
I'm cool with it! |
Seems legit to me, let's go 🥳 |
See #624.
All Thanks Given @LeoSpyke 🙏
Is there a someone who can glance over it and do some sort of quick proofreading? That be awesome 🧡