Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add italian translation it 🇮🇹 #627

Merged
merged 8 commits into from
Jul 3, 2023
Merged

Conversation

theborakompanioni
Copy link
Collaborator

See #624.

All Thanks Given @LeoSpyke 🙏

Is there a someone who can glance over it and do some sort of quick proofreading? That be awesome 🧡

@theborakompanioni theborakompanioni added the i18n Issues related to translation and internationalisation (i18n) label Jun 27, 2023
@theborakompanioni theborakompanioni changed the title feat(i18n): add italian translation it feat(i18n): add italian translation it 🇮🇹 Jun 27, 2023
@LeoSpyke
Copy link

LeoSpyke commented Jun 27, 2023

Maybe @httpiga?

edit: I have just a little concern about the translation of "sweep"-related words, which is absolutely awful in Italian 😅

@httpiga
Copy link
Contributor

httpiga commented Jun 27, 2023

Thanks for tagging me! Sure, I'll take a look at this ASAP

@theborakompanioni theborakompanioni assigned httpiga and LeoSpyke and unassigned httpiga Jun 27, 2023
Copy link
Contributor

@httpiga httpiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the number of comments but once I noticed I needed to start a review instead of writing single comments, it was too late 😅
This is great work, congratulations! 🎉
I left some comments with open discussion and others about typos or wrong placeholders.
As you mentioned, the "Sweep" function translation isn't so nice to read, what about embracing language contamination and keeping it as "Sweep"?
(I'd also like to suggest the same for the "Earn" translation but it's a merely personal preference)

@LeoSpyke
Copy link

Thank you for your feedback. I've added a couple of comments, but they are just refinements.
And, Yeah, let's embrace the contamination and avoid to write something we might regret in the future :D

Copy link
Contributor

@httpiga httpiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked again all my suggestions but I trust, don't verify that you corrected all the flagged errors. Thank you for your contribution! 😄

@theborakompanioni
Copy link
Collaborator Author

theborakompanioni commented Jul 2, 2023

I haven't checked again all my suggestions but I trust, don't verify that you corrected all the flagged errors. Thank you for your contribution! smile

Thank you guys!

I applied all the suggestions marked with ":+1:" -> The discussions still open have no change suggestions. If you want to make changes, would you add a change suggestions so I can apply it?
After merging, I'll transfer the changes to the Transifex translation so the docs stay synchronized. I think that is the easiest approach - okay for both of you @LeoSpyke @httpiga ? 🙏

@httpiga
Copy link
Contributor

httpiga commented Jul 2, 2023

I'm cool with it!

@LeoSpyke
Copy link

LeoSpyke commented Jul 3, 2023

Seems legit to me, let's go 🥳

@theborakompanioni theborakompanioni merged commit 068042f into master Jul 3, 2023
@theborakompanioni theborakompanioni deleted the i18n/it branch July 3, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues related to translation and internationalisation (i18n)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants