Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Translation in Brazilian Portuguese #615

Merged
merged 7 commits into from
Apr 22, 2023

Conversation

KoreaComK
Copy link
Contributor

Hi,

I finished the translation to Brazilian Portuguese of the app using the transifex.

Cheers,

KoreaComK and others added 3 commits April 20, 2023 17:27
100% translated for the source file 'src/i18n/locales/en/translation.json'
on the 'pt_BR' language.
Translate 'src/i18n/locales/en/translation.json' in 'pt_BR'
@theborakompanioni theborakompanioni added enhancement New feature or request i18n Issues related to translation and internationalisation (i18n) labels Apr 21, 2023
@theborakompanioni theborakompanioni added this to the v0.1.6 - TBD milestone Apr 21, 2023
@theborakompanioni
Copy link
Collaborator

Nice @KoreaComK , what a wonderful service to all Portuguese speaking people 🙏

Would it be possible to delete one of the two translation files? Just keep either pt_BR or ptbr - I'd opt for keeping the pt_BR one, if you are okay with it. Also, please run npm run format to make the linter happy. After that, happy to merge 🎉

Folder and file of ptbr deleted.
Changes in the languages.js to get the correct file made.
@KoreaComK
Copy link
Contributor Author

@theborakompanioni thanks for helping.
I run the npm run format and it changes package-lock.json and package.json. I didn't put both in this commit, since it just change the version of prettier.
Also I deleted the folder and file ptbr as mention, and changed the imports on language.js .
If it needs anything else, please, let me know.

Cheers!

@theborakompanioni theborakompanioni self-requested a review April 22, 2023 10:46
Copy link
Collaborator

@theborakompanioni theborakompanioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. 🇵🇹 🇧🇷

@theborakompanioni theborakompanioni merged commit 4d9171e into joinmarket-webui:master Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18n Issues related to translation and internationalisation (i18n)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants