Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no. of collaborators as integer #572

Merged
merged 2 commits into from
Dec 9, 2022
Merged

fix: no. of collaborators as integer #572

merged 2 commits into from
Dec 9, 2022

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Nov 30, 2022

Before this PR, Jam displayed and sent a fractional number as collaborators to the backend (which rounded down to the nearest int). After this commit is applied the number of collaborators as always parsed and displayed as integer.

Before:
image

After:
image

@theborakompanioni theborakompanioni added the bug Something isn't working label Nov 30, 2022
@theborakompanioni theborakompanioni self-assigned this Nov 30, 2022
@theborakompanioni theborakompanioni requested review from secondl1ght and editwentyone and removed request for secondl1ght November 30, 2022 14:01
@theborakompanioni theborakompanioni marked this pull request as ready for review December 3, 2022 13:04
Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tACK ✅

Small NIT: imho it would be better if the input field wouldn't allow nonsense in the first place, but that's just me. This PR is definitely an improvement, so I'll merge it as is.

@dergigi dergigi merged commit 4fca8f1 into master Dec 9, 2022
@dergigi dergigi deleted the fix/collab-integer branch December 9, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants