fix(sweep): wait for scheduler start/stop #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
bug
dergigi
approved these changes
Oct 3, 2022
dergigi
reviewed
Oct 3, 2022
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <PageTitle title={t('scheduler.title')} subtitle={t('scheduler.subtitle')} /> | ||
| {alert && <rb.Alert variant={alert.variant}>{alert.message}</rb.Alert>} | ||
|
|
||
| {isLoading ? ( | ||
| {isLoading || isWaitingSchedulerStart || isWaitingSchedulerStop ? ( | ||
| <rb.Placeholder as="div" animation="wave"> |
There was a problem hiding this comment.
Unrelated to this PR, but I thought I'd mention it anyway: I'm not sure how animation="wave" should look like, but this is how the loading state looks for me when starting/stopping the scheduler:
Independent of the changes in this PR, and independent of browser (Firefox and Chromium).
There was a problem hiding this comment.
Yep, this is "expected". Should resemble either the "start"/"stop" button or the "Service already running"-alert.
Any inputs highly appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267.
Before this PR, the Sweep screen did not wait for an operation to start/stop and assumed the operation will succeed.
After this PR, the screen will show a loading indicator till the service has been successfully started/stopped.