Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show sum of selected utxos #514

Merged
merged 9 commits into from
Sep 26, 2022
Merged

feat: show sum of selected utxos #514

merged 9 commits into from
Sep 26, 2022

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Sep 22, 2022

Resolves #440.

Changes:

  • show sum of selected utxos
  • adapt margins/paddings to better match figma screens
  • wording according to figma:
    • "Jar Details" -> "Details"
    • "Freeze/unfreeze selected" -> "Freeze/unfreeze"

@theborakompanioni theborakompanioni added the UI/UX Issue related to cosmetics, design, or user experience label Sep 22, 2022
@theborakompanioni theborakompanioni self-assigned this Sep 22, 2022
@theborakompanioni theborakompanioni changed the title feat: show sum selected utxos feat: show sum of selected utxos Sep 22, 2022
@theborakompanioni theborakompanioni marked this pull request as ready for review September 22, 2022 16:01
Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future improvement: If nothing is selected, we could show the total amount that is in the jar in the same place. Tracked as #517

No selection: 12,773,047,386 sats in total
With selection: 28,044 sats selected

But this looks good as is. tACK ✅

src/i18n/locales/en/translation.json Outdated Show resolved Hide resolved
@dergigi dergigi merged commit 85d131c into master Sep 26, 2022
@dergigi dergigi deleted the show-sum-selected-utxos branch September 26, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show sum of selected UTXOs in UTXO list
2 participants