Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo #65

Open
frithuric opened this issue Feb 2, 2018 · 8 comments
Open

Undo #65

frithuric opened this issue Feb 2, 2018 · 8 comments

Comments

@frithuric
Copy link

We're using this on a touchy touchscreen or sensitive mouse and too often accidentally get an extra click. It would be great to have an undo button to roll back the actions.

@GinoGalotti
Copy link
Collaborator

This would be amazing although, with the current way we're doing everything, it would be quite hard to implement. We can try to save the state to go back. This would be easier if we port the app to a framework... :) any volunteer?

@frithuric
Copy link
Author

frithuric commented Feb 28, 2018 via email

@GinoGalotti
Copy link
Collaborator

Well, I joined it half way. We were all programmers, but JS is not our thing; that's why we decided to keep it plain (no frameworks). It was nice, because everyone could do small things without really leaning the framework first but... it ended up limiting us. Matt spent some time migrating it to https://mithril.js.org/, but we stopped having spare time to invest on this. Feel free to give it a go!

@stellentus
Copy link

I like working in Mithril, but I think realistically I can't commit the time, either. I'd be available for review/feedback/questions if someone without experience in Mithril continues the work.
Is Matt's in-progress branch available somewhere (just in case I or someone wants to work on it)?

@GinoGalotti
Copy link
Collaborator

@stellentus https://github.com/mwinckler/gloomycompanion/tree/mithril, I assume? Haven't talked with him in a year, give or take.

@mwinckler
Copy link
Collaborator

Hey @stellentus, the branch Gino linked is indeed the one. It's a branch on my fork, but it should probably just be its own repo as I pretty much decided to start from scratch in porting to a framework. I also had a few work-in-progress changes locally that I never got around to pushing, so I did that just now.

I didn't get too far and I'm not that fluent in mithril, so I was still playing around and learning the best way to organize things. If you do pick it up and run with it, ping me - I'd enjoy following progress and learning.

@skarnl
Copy link

skarnl commented Apr 1, 2018

I'm a webdeveloper, loving this app and Gloomhaven... and looking for a pet project. So I might take a stab at it, maybe forking it to something like Vue.js and using Bootstrap or anything. But not sure if that's what you are looking for. It might become something completely different in structure and such ^^

@GinoGalotti
Copy link
Collaborator

:) Up yo you, @skarnl. We barely maintain it right now, I spend most of the time just merging and fixing problems when merging... not really "further development". So, if you feel that you'll be active and want to move it to a framework... feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants