Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotenv does not report an error if file does not exist #192

Open
maffka123 opened this issue Aug 19, 2022 · 2 comments
Open

dotenv does not report an error if file does not exist #192

maffka123 opened this issue Aug 19, 2022 · 2 comments

Comments

@maffka123
Copy link

Hi,

Is there any particular reason why there is no return err here
godotenv.go line 71 in Overload()

Like that it silently fails if it cannot find a file..

@BigBallard
Copy link

BigBallard commented Sep 12, 2022

@maffka123 that is not really an error though. Most other dotenv implementations in other languages do not expose an error when the file is not found.
However, if you feel this is worth doing, go ahead and do a PR with those changes. Should be pretty easy.

Edit
Rather, just fork, this repo is effectively done.

@egasimov
Copy link

egasimov commented Feb 15, 2023

@maffka123 , it looks like similar issue described here
I've just made two PRs for resolving the issue you mentioned before with different approaches, it is still in pending because of repo is effectively done.

You may check them. PR-1 , PR-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants