Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ASM 7.3.1 to support JDK 15 #549

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

vyazelenko
Copy link
Contributor

@johnrengelman Any estimate on when the next version of the Shadow plugin will be released?

@johnrengelman johnrengelman merged commit 93e417f into GradleUp:master Mar 7, 2020
@johnrengelman johnrengelman added this to the 6.0 milestone Mar 7, 2020
@VoxelGod
Copy link

VoxelGod commented Jun 17, 2020

Unfortunately, a JDK 14 and 15 preview feature (records) requires ASM 8. I haven't tested instanceof pattern matching.

* What went wrong:
Execution failed for task ':shadowJar'.
> Records requires ASM8

@johnrengelman
Copy link
Collaborator

@VoxelGod
Copy link

@johnrengelman One of my colleagues inspected the stacktrace (https://hastebin.com/egemarucaw.txt) and found ASM7 references in jdependency to be responsible:
https://github.com/tcurdt/jdependency/blob/c2e760c533225d313c5ef8e1d1f14840591bf431/src/main/java/org/vafer/jdependency/asm/DependenciesClassAdapter.java#L128

I can notify them of the issue, then jdependency would need to be updated in ShadowJar as well.

@johnrengelman
Copy link
Collaborator

Looks like jdependency 2.4.0 uses ASM 8

@VoxelGod
Copy link

Is it possible this dependency update could be targeted for a minor release in the future? For now, I'll exclude records from my project.

@bridgettewp
Copy link

bridgettewp commented Jun 19, 2020

Encountering the same issue with JDK 14 preview features. Records throw a TaskExecutionException. Relocation and minimization do work now, though.

Just confirmed instanceof pattern matching does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants