Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid UnusedTracker creation when minimizeJar is not requested #480

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Avoid UnusedTracker creation when minimizeJar is not requested #480

merged 1 commit into from
Jun 29, 2019

Conversation

sormuras
Copy link
Contributor

@sormuras sormuras commented Apr 3, 2019 •
edited
Loading

Closes #479

@sormuras
Copy link
Contributor Author

Ping @johnrengelman ... any plans to include this PR or implement some other measure to help with UnusedTracker issues?

@marcphilipp
Copy link
Contributor

@johnrengelman Any chance of getting this merged? We currently have to use a fork of the plugin in junit5. https://github.com/junit-team/junit5/blob/02417272bb22b8c710a0f58bc98505a49ef82107/settings.gradle.kts#L15

@sormuras
Copy link
Contributor Author

Any news?

@cowwoc
Copy link

cowwoc commented Jun 27, 2019

@johnrengelman Please merge this.

@sormuras
Copy link
Contributor Author

Yeah, would be great to get rid of this work-around junit-team/junit5@c4a2a7b

@johnrengelman johnrengelman merged commit 8d2181e into GradleUp:master Jun 29, 2019
@sormuras sormuras deleted the no-minimize-no-tracker branch June 29, 2019 03:33
sormuras added a commit to junit-team/junit5 that referenced this pull request Jun 29, 2019
@sormuras
Back to @johnrengelman shadow plugin distribution
a48d9b4 
Still using jitpack until the new 5.x version is released.

GradleUp/shadow#480
@sormuras
Copy link
Contributor Author

Thanks for merging, @johnrengelman!

Already updated our Gradle configuration to your latest master revision built on-the-fly via JitPack.

@johnrengelman johnrengelman added this to the 5.1.0 milestone Jun 29, 2019
sormuras added a commit to junit-team/junit5 that referenced this pull request Jun 30, 2019
@sormuras
Upgrade Shadow Gradle Plugin to 5.1.0
571d90b 
GradleUp/shadow#480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

Avoid UnusedTracker creation
4 participants
@sormuras @marcphilipp @cowwoc @johnrengelman