Minimize - Excluding a project also excludes its dependencies #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpalcolea
changed the title
…inimize-project-excludes-tests
|
Hi @johnrengelman , any chance you could take a look on this one? |
johnrengelman
approved these changes
Jan 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @johnrengelman ,
This is related to #419. Wonder if it makes sense.
Also, decided to only apply this logic on its own
DependencyFilter. So moved common things toAbstractDependencyFilterand nowDefaultDependencyFilterandMinimizeDependencyFilteronly implement the way it's getting determine if a dependency should be included or not. This way the change doesn't impact existing users of shadow that might not want that with common filtering (not for minimize)