Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid UnusedTracker creation #479

Closed
sormuras opened this issue Apr 3, 2019 · 0 comments · Fixed by #480
Closed

Avoid UnusedTracker creation #479

sormuras opened this issue Apr 3, 2019 · 0 comments · Fixed by #480

Comments

@sormuras
Copy link
Contributor

sormuras commented Apr 3, 2019 •
edited
Loading

Even if a project using shadow doesn't configure minimizeJar=true, the UnusedTracker is instantiated. This is a) unneccessary and b) fails sometimes in multi-module projects. See #425 and related PRs: #477 and #478 (which both introduce new erros) for details on those failures.

So, what about not creating an instance of UnusedTracker at all when minimize is not requested?

The failures described in b) are not touched by this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid UnusedTracker creation when minimizeJar is not requested
1 participant
@sormuras