Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jQuery 3.x #10

Open
Sander-Toonen opened this issue Jul 29, 2016 · 5 comments
Open

Allow jQuery 3.x #10

Sander-Toonen opened this issue Jul 29, 2016 · 5 comments

Comments

@Sander-Toonen
Copy link

As far as I can tell. Toastr is working fine with jQuery 3.x.
Could you please update the bower.json file to allow jQuery version 3 as a dependency?

@matthijs-oosterhoff
Copy link

Same here 👍

@arcenik
Copy link

arcenik commented Dec 1, 2016

This issue has not been fixed on bower public registry.

I've just installed the component and I have this statement :

└─┬ toastr#2.1.3
  └── jquery#3.1.1 incompatible with >=1.6.3 <3 (2.2.4 available, latest is 3.1.1)

@axlekb
Copy link

axlekb commented Feb 5, 2017

Any chance this could be fixed on 2.1.3? It seems as though its on master, but not 2.1.3.

Thanks!

@doubleaxe
Copy link

The workaround is to reference commit id instead of version number in bower. Like this:
bower install toastr#113a6f6 --save
or
bower install https://github.com/johnpapa/toastr-bower.git#113a6f6 --save

@michaelbrawn
Copy link

michaelbrawn commented Jan 22, 2018

I've made a new pull request updating to a new version in order to properly include the most recent commit that removes the jQuery 3 dependency.
If a new release is published that points at the most recent commit tagged as 2.1.4, this should fix the problem.
#13

This will fix an issue when the library is incorporated into a Rails gem, and the jQuery 3 dependency change isn't included on https://rails-assets.org/#/components/toastr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants