Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inside a book, Ctrl+F search keyboard shortcut does not work if the book pages are focused instead of the sidebar #1299

Closed
nekohayo opened this issue Apr 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nekohayo
Copy link

To Reproduce
Steps to reproduce the behavior:

  1. Enter a book
  2. Click on the Search button
  3. Press Esc to toggle off the search
  4. Press Ctrl+F, notice the searchbar reappears
  5. Press Esc to toggle off the search
  6. Click the book's page contents on the right, so that the focus is no longer on the sidebar (even if the sidebar is pinned)
  7. Press Ctrl+F to try to activate and focus (and select-all) the searchentry's contents

Expected behavior
Search entry gets reactivated, and existing query text (if any) should be all preselected (so that the user can replace/overwrite it, or choose to extend it instead)

Version:

  • Foliate version: 3.1.0
  • OS/Distribution and version: Fedora 39
  • Desktop environment: GNOME 45
  • Installation method: RPM

Additional context
Running in Wayland.

@nekohayo nekohayo added the bug Something isn't working label Apr 12, 2024
@nekohayo nekohayo changed the title Inside a book, Ctrl+F search shortcut does not work if the book pages are focused instead of the sidebar Inside a book, Ctrl+F search keyboard shortcut does not work if the book pages are focused instead of the sidebar Apr 12, 2024
@johnfactotum
Copy link
Owner

See #1279 (comment)

  • OS/Distribution and version: Fedora 39

  • Desktop environment: GNOME 45

Guess that means it was caused by a change in how WebKitGTK handles shortcuts.

At any rate, this should be fixed in v3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants