Liberate "build-essential" version constraint #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 73.68%@@ master #63 diff @@
==========================================
Files 2 2
Lines 95 95
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 49 70 +21
+ Misses 46 25 -21
Partials 0 0
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can see, there is no any reason to pin
build-essentialversion in this cookbook. However, it may cause some conflicts with other cookbooks, like I've noticed here: #62 (comment)build-essentialis one of fundamental library cookbook used by a lot of other cookbooks as a dependency. So, if it's really needed, then it's better for users to pinbuild-essentialversion on the top level, like wrapper cookbook, env cookbook, or Chef Environment, according to release noteshttps://github.com/chef-cookbooks/build-essential/blob/master/CHANGELOG.md