vault_secret: Raise an exception if Vault read has failed

[legal90]

I think, like in Chef Data Bags, there should be a run failure if the specified secret could not be read by some reason. Otherwise, it makes people to write additional wrappers for checking the secret value.

[legal90]

BTW, Seth Vargo has also used raise in his gist

[Ginja]

I see why this would be useful, but sometimes secrets are used in one-time resources (e.g. an execute). It would be annoying to have it fail on one of these secrets if there was a temporary issue reaching the Vault server. What do you think about exposing this as another property? exit_on_error and set it to false by default?

Also, I think I'd rather see Chef::Application.fatal!('') than raise. It's more chef-friendly & consistent with how it exits the run. I lied, continue using raise.

[codecov-io]

Current coverage is 73.68%

Merging #61 into master will increase coverage by 22.10%

@@             master        #61   diff @@
==========================================
  Files             2          2          
  Lines            95         95          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             49         70    +21   
+ Misses           46         25    -21   
  Partials          0          0          

Powered by Codecov. Last updated by 504136d...93c4316

[legal90]

Sorry for a long delay.
I've updated the pull-request by adding exit_on_error option.

It would be annoying to have it fail on one of these secrets if there was a temporary issue reaching the Vault server.

Sorry, I don't think that it is a reason to make this resource loyal to failures like this. If the secret could not be read by any reason, then it should be considered as an error and an operator should be notified. That's why I've set exit_on_error to true by default.

@johnbellone What do you think about it?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.