Fixed Install Issues #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ginja
commented
Mar 3, 2016
Ginja
commented
- Re-named prefix from vault to hashicorp-vault to fix inversion error
- Added attributes to vault_config
- Re-worked to_json method to place configs in appropriate sections
- Fixed incorrect method call in vault_installation_binary provider
- Added vault 0.5.1 checksums
- Added 'server' arguement to service.command
* Re-named prefix from vault to hashicorp-vault to fix inversion error * Added attributes to vault_config * Re-worked to_json method to place configs in appropriate sections * Fixed incorrect method call in vault_installation_binary provider * Added vault 0.5.1 checksums * Added 'server' arguement to service.command
|
Fully expecting the spec tests to fail at this point. |
|
|
||
| def tls? | ||
| return true unless %w{1 true}.include?(tls_disable) && manage_certificate | ||
|
|
||
| if manage_certificate |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The evaluation of the manage_certificate property didn't belong in the same method that determines whether or not we're using TLS with vault. A user may want to implement certificate management in their wrapper cookbook.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.