Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve poll priority handling #1036

Closed
MarkusGH opened this issue Oct 10, 2023 · 1 comment
Closed

Improve poll priority handling #1036

MarkusGH opened this issue Oct 10, 2023 · 1 comment

Comments

@MarkusGH
Copy link

MarkusGH commented Oct 10, 2023

Description

Currently messages with lower poll priority are sent in blocks.

This leads to the unwanted (at least by me) behaviour that messages with lower poll priority can still significantly delay messages with higher poll priority.

Example:

r1 A
r5 B
r5 C
r5 D
r5 E
r5 F

Currently this will be sent like:

AAAAABCDEF AAAAABCDEF etc.
So the interval between the A messages (with poll priority 1) is 11116 111116 poll cycles (min 1, max 6, average 2 cycles).
The delay between the BCDEF messages (with poll priority 5) is always 10 cycles as expected (5 times longer).

A IMHO better sequence would be:

ABACADAEAF ABACADAEAF etc.

For that reason I suggest to pick the next poll message in a round-robin like fashion.

@john30
Copy link
Owner

john30 commented Oct 14, 2023

duplicate of #129

@john30 john30 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants