Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Error in "Check Broken URLs" #85

Closed
IsuminI opened this issue Nov 26, 2024 · 6 comments · Fixed by #86
Closed

Additional Error in "Check Broken URLs" #85

IsuminI opened this issue Nov 26, 2024 · 6 comments · Fixed by #86
Assignees
Labels
bug Something isn't working

Comments

@IsuminI
Copy link
Contributor

IsuminI commented Nov 26, 2024

Describe the bug
Through Issue #84, I confirmed that the Markdown checker version in this repository has been updated to 0.2.2. I verified that the following two links pass without any issues:

However, I found that the following link is causing an error:

https://github.com/microsoft/generative-ai-for-beginners/actions/runs/12005917466/job/33463433188?pr=640 (job action site)
When tested locally, this link did not show any problems.

Expected behavior
The URL should not be included in the error list.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome
  • Version: 131.0.6778.86

Additional context
I'm not very experienced with writing issues, so if there's anything incorrect, I'd appreciate it if you could let me know. Thank you! 😊

@john0isaac
Copy link
Owner

We will add this domain to skipped domains list.
PRs are welcome!

Thanks for reporting!

@IsuminI
Copy link
Contributor Author

IsuminI commented Nov 26, 2024

Thank you! 😆
Have a nice day :)

@IsuminI
Copy link
Contributor Author

IsuminI commented Nov 26, 2024

Should I understand this as meaning that I should send the PR myself?
I'm leaving a comment because I'm not good at English.
Thank you!

@john0isaac
Copy link
Owner

john0isaac commented Nov 26, 2024

if you want yes feel free to do so

all you need to do is to add this "opensource.org" to this list:
https://github.com/john0isaac/markdown-checker/blob/2f0aa541e7bf3adbe19f8e7f72e1978335c438b6/src/markdown_checker/__init__.py#L75C9-L98C10

@IsuminI
Copy link
Contributor Author

IsuminI commented Nov 26, 2024

Thank you so much!

@john0isaac
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants