Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][querydb] Fix comment in UseAfterFree query #5114

Closed
HamzaMouhcine opened this issue Nov 18, 2024 · 0 comments
Closed

[Docs][querydb] Fix comment in UseAfterFree query #5114

HamzaMouhcine opened this issue Nov 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@HamzaMouhcine
Copy link
Contributor

In the file querydb/src/main/scala/io/joern/scanners/c/UseAfterFree.scala, the free-follows-value-reuse query has a comment in the "the query does not match" examples. The comment states that the return x is not post-dominated by the free call, I believe this is not what the author meant as this statement is not relevant to what the query is doing. This could confuse users. I believe the author wanted to write the following comment instead return x doesn't post-dominate the free call.

I opened a pr with a fix here.

@HamzaMouhcine HamzaMouhcine added the bug Something isn't working label Nov 18, 2024
@maltek maltek closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants