Installation Issues

[akaszynski]

Hello,

I'm reviewing your submission for JOSS and having a tough time getting started installing your library. I'd suggest the following:

• Provide a package of your library on PyPi
• Check for an installation of OGS and then raise a descriptive error when the application is missing. For example, immediately after:
  

  ogs6py/ogs6py/ogs.py

  Lines 114 to 117 in 354945b

  	if sys.platform == "win32":
  	ogs_path = os.path.join(ogs_path, "ogs.exe")
  	else:
  	ogs_path = os.path.join(ogs_path, "ogs")

  
  Add a test if the file exists with os.path.isfile, and then point the user to a url containing application installation directions.
• Avoid non-descriptive runtime errors:
  

  ogs6py/ogs6py/ogs.py

  Line 139 in 354945b

  raise RuntimeError

Cheers!
Alex

[leouieda]

Related to openjournals/joss-reviews#3673 (so we can see the status in the review issue)

[joergbuchwald]

Hi @akaszynski,
thanks for reviewing. Concerning the first point, ogs6py is already on PyPI: https://pypi.org/project/ogs6py/
Perhaps, I should add that to the installation instructions as well...

[akaszynski]

thanks for reviewing. Concerning the first point, ogs6py is already on PyPI: https://pypi.org/project/ogs6py/
Perhaps, I should add that to the installation instructions as well...

Ha! I feel stupid for not even looking. Yes, directions would be helpful for that.