Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip of binary distribution of CLI #500

Closed
eliocapelati opened this issue Feb 3, 2016 · 8 comments
Closed

Zip of binary distribution of CLI #500

eliocapelati opened this issue Feb 3, 2016 · 8 comments
Milestone

Comments

@eliocapelati
Copy link

In the release channel via github please make available the binary of CLI distribution under a zip. This release enable the opportunity that the jsonschema2pojo is installed via sdkman.

@joelittlejohn
Copy link
Owner

Oh, thanks for reporting this. It looks like the binary upload is no longer appearing in the way it should for the last few releases.

Is sdkman able to work with a .tar.gz?

@marc0der
Copy link

marc0der commented Feb 3, 2016

We don't currently support tarballs because of discepencies between bsd and gnu tar. Sdkman expects a zip in a fairly standard SDK distribution format:

  • zip contains a folder like jsonschem2pojo-${version}
  • this in turn contains bin and lib folders for executables and jars respectively.

If you could publish such a zip on say BinTray (or wherever you like), we could easily integrate this into our platform.

Also, we can let you perform your own releases if you like, for more info, please see our vendors page.

@joelittlejohn joelittlejohn added this to the 0.4.20 milestone Feb 3, 2016
@joelittlejohn
Copy link
Owner

Okay, so the failed uploads are just a coincidence :) GitHub has changed URL template for release uploads in a way that broke my release script, so the tars are missing from the last few versions. Thanks for helping me find that :D

I can easily add a .zip upload so that it will appear in the Download section here:

https://github.com/joelittlejohn/jsonschema2pojo/releases/tag/jsonschema2pojo-0.4.19

This would be a good time to review how the contents of the binary are structured anyway because there is stuff in there that is redundant IMO. I'll look to do this for the next release.

@marc0der
Copy link

marc0der commented Feb 3, 2016

That sounds great, we would be happy to help you distribute your cool tool!

@eliocapelati
Copy link
Author

Thanks a lot guys!! These two tools is helping a lot of JVM developers!!!

@joelittlejohn joelittlejohn modified the milestones: 0.4.21, 0.4.20 Feb 21, 2016
@joelittlejohn joelittlejohn added this to the 0.4.23 milestone Mar 20, 2016
@joelittlejohn
Copy link
Owner

The changes have been made here and there is a release that delivers the binary you need (I think):

https://github.com/joelittlejohn/jsonschema2pojo/releases/tag/jsonschema2pojo-0.4.23

Let me know if there are any more changes required.

@marc0der
Copy link

marc0der commented May 31, 2016

Just downloaded the binary and it's looking better. It still needs a bin folder containing the executables though. Shall we keep this issue open until we have confirmed that it's working as expected?

@joelittlejohn joelittlejohn reopened this May 31, 2016
@joelittlejohn joelittlejohn modified the milestones: 0.4.28, 0.4.23 Dec 5, 2016
@joelittlejohn joelittlejohn reopened this Dec 5, 2016
@joelittlejohn
Copy link
Owner

Fixed with the latest binaries available here:

https://github.com/joelittlejohn/jsonschema2pojo/releases/tag/jsonschema2pojo-0.4.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants