I will fix the tests and add a new one in case we agree on the desire to have this change merged in.

Atom already adds a new line and trims spurious newlines from the end of a file on save. Are you really seeing more than 1 blank line at the end of a file?

The whitespace package has an option to ensure a trailing empty new line. I
disabled this. All files are fine, except the ones formatted using the
gofmt package in Atom. Is it maybe because of the package execution order?
Maybe the whitespace plugin kicks in before gofmt. In any case, the current
behavior is annoying. Do you experience another behaviour? Do your go files
not have trailing empty new lines when using this package here?

On Fri, 21 Oct 2016, 18:30 Joe Fitzgerald, [email protected] wrote:

Atom already adds a new line and trims spurious newlines from the end of a
file on save. Are you really seeing more than 1 blank line at the end of a
file?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#49 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAhvQWoFaYhPeN74vPZjiwnf9s-nOvajks5q2OiRgaJpZM4KdUzS
.

I think this PR is wrong and does not fix anything. I am closing this now. Thanks for listening.