Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage Collection #94

Closed
guero235 opened this issue Dec 6, 2016 · 5 comments
Closed

Garbage Collection #94

guero235 opened this issue Dec 6, 2016 · 5 comments

Comments

@guero235
Copy link

guero235 commented Dec 6, 2016

Quick question for you. My apologies if i don't understand everything - i've only been using this library for a few days. I am using it as a http2 client that send push notifications to apple.

For example - here is some debuging output:

added stream #3 to {stream_set,client,{peer_subset,500,1,0,5,[{closed_stream,1,<0.2105.0>,[{<<":status">>,<<"200">>},{<<"apns-id">>,<<"b811c1d3-e19a-4721-9687-1f7560e005ee">>}],[],false},{active_stream,3,<0.2297.0>,<0.2105.0>,65535,65535,undefined,false}]},{peer_subset,unlimited,0,0,2,[]}} 

I've noticed that even though i've called h2_client:get_response it stays in the stream_set. Do i need to go through the closed streams and set the garbageproperty to true? Or is there a better way to mark it after i've dealt with it?

@efine
Copy link
Contributor

efine commented Apr 17, 2017

@guero235 , did you ever get an answer to this? I am finding the same issue.

@guero235
Copy link
Author

@efine, unfortunately, no. I made my own dispose function that i call when i'm done with the stream to clean it up. I can post the code here if you'd like.

@efine
Copy link
Contributor

efine commented Apr 18, 2017

@guero235 , it looks as if PR #106 solves this issue!

@guero235
Copy link
Author

guero235 commented Apr 18, 2017

Thanks for the update. I also use mine for APNS and my solution has been working for me. I simply dispose of the stream after i have read the response from Apple to keep it clean.

@tsloughter
Copy link
Collaborator

I'm closing this since I've merged #106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants