Update simple_form.rb #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@joecorcoran DEPRECATION WARNING: judge method now accepts a wrapper_options argument. The method definition without the argument is deprecated and will be removed in the next Simple Form version. Change your code from: def judge to def judge(wrapper_options) See heartcombo/simple_form#997 for more information. (called from render at ........../bundler/gems/simple_form-6c9e69b22f63/lib/simple_form/wrappers/leaf.rb:15) This just solve the deprecation warning! We should merge it
|
Thanks @Dinuz. Tests are failing due to a combo of simple_form v2 and 3 support. I'll release this as v1.0 and deprecate simple_form v2 support. |
This was referenced May 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joecorcoran
DEPRECATION WARNING: judge method now accepts a wrapper_options argument. The method definition without the argument is deprecated and will be removed in the next Simple Form version. Change your code from:
def judge
to
def judge(wrapper_options)
See heartcombo/simple_form#997 for more information.
(called from render at ........../bundler/gems/simple_form-6c9e69b22f63/lib/simple_form/wrappers/leaf.rb:15)
This just solve the deprecation warning!
We should merge it