From 64a2f0530fd9099de2cb1026a61e0a31b05e983d Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Tue, 18 Jul 2017 14:28:58 +0200 Subject: [PATCH] Revert to old yauzl version Revert "Take yauzl update but keep devDeps, temporarily" This reverts commit 9dddf4f0890aaf178f9c18de436aaaca063ef58e. Revert "Handle error from github.downloadAsset" This reverts commit b8fd6a98b839b96e74e048557fd2bfd4837e88b5. Revert "Update to fix with latest yauzl, and fix #3" This reverts commit 8176795d470d6ba3781871cf50a284027adc411b. --- dist/download.js | 5 ----- package.json | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/dist/download.js b/dist/download.js index 61b840e..043ff48 100644 --- a/dist/download.js +++ b/dist/download.js @@ -36,10 +36,6 @@ function download(opts, assetName, downloadDest) { const assetDownloadPath = path.join(downloadDest, assetName); github.downloadAsset(asset, (error, istream) => { - if (error) { - return reject(error); - } - console.log(`Downloading to ${assetDownloadPath}`); if (process.stdout.isTTY && !opts.quiet) { const bar = new ProgressBar('↓ ' + asset.name + ' [:bar] :percent', { @@ -68,7 +64,6 @@ function unzip(zipPath, destinationDir) { yauzl.open(zipPath, { lazyEntries: true }, (err, zipFile) => { if (err) return reject(err); - zipFile.readEntry(); zipFile.on('entry', entry => { zipFile.openReadStream(entry, (err, readStream) => { if (err) return reject(err); diff --git a/package.json b/package.json index 6f69032..35aa9d9 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "vscode-ripgrep", - "version": "0.0.15", + "version": "0.0.12", "description": "Downloads the ripgrep binary shipped in VS Code", "main": "dist/index.js", "repository": { @@ -16,6 +16,6 @@ "github-releases": "^0.3.2", "mkdirp": "^0.5.1", "progress": "^1.1.8", - "yauzl": "^2.8.0" + "yauzl": "2.3.1" } }