Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashes nested inside of arrays not properly parsed in query params / body. #574

Closed
sealabcore opened this issue Feb 22, 2018 · 3 comments
Closed

Comments

@sealabcore
Copy link

sealabcore commented Feb 22, 2018

Example hash payload that does not parse properly:

{:marketing_event => { :marketed_resources=>[{:type=>"product", :id=>57474842640}]}}

The resulting string is marketing_event[marketed_resources][][type]=product. You can see that the id is completely omitted from the resulting string.

This could have been a result of the refactor of this class in the latest version.
https://github.com/jnunemaker/httparty/blob/master/lib/httparty/hash_conversions.rb

@jnunemaker
Copy link
Owner

Thanks for the report. I'd be up for a PR. I can try to tackle it at some point, but I'm not sure when. If anyone else has time, let me know.

@jmortlock
Copy link
Contributor

Hi @jnunemaker I have add a PR which fixes this, let me know if you need anything extra to get this merged.

@jnunemaker
Copy link
Owner

Closed by #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants