Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-demand queries never get completed #577

Closed
javuto opened this issue Dec 27, 2024 · 2 comments
Closed

On-demand queries never get completed #577

javuto opened this issue Dec 27, 2024 · 2 comments
Labels
🐛 bug Something isn't working osctrl-tls osctrl-tls related changes queries On-demand queries related issues

Comments

@javuto
Copy link
Collaborator

javuto commented Dec 27, 2024

If an on-demand query is queued up, and the target picks it up and results are returned. But the results keep coming in. It may be related to what merged in #558

@javuto javuto added 🐛 bug Something isn't working osctrl-tls osctrl-tls related changes queries On-demand queries related issues labels Dec 27, 2024
@javuto
Copy link
Collaborator Author

javuto commented Dec 27, 2024

Found the root cause:

osctrl-tls-dev       | 2024/12/27 19:31:40 /usr/src/app/queries/queries.go:502 ERROR: value too long for type character varying(8) (SQLSTATE 22001)
osctrl-tls-dev       | [0.466ms] [rows:0] UPDATE "node_queries" SET "status"='completed',"updated_at"='2024-12-27 19:31:40.977' WHERE "node_queries"."deleted_at" IS NULL AND "id" = 2
osctrl-postgres-dev  | 2024-12-27 19:31:40.982 UTC [940] ERROR:  value too long for type character varying(8)
osctrl-tls-dev       | {"level":"error","error":"ERROR: value too long for type character varying(8) (SQLSTATE 22001)","time":"2024-12-27T19:31:40Z","caller":"/usr/src/app/logging/process.go:91","message":"error updating query status"}
osctrl-postgres-dev  | 2024-12-27 19:31:40.982 UTC [940] STATEMENT:  UPDATE "node_queries" SET "status"=$1,"updated_at"=$2 WHERE "node_queries"."deleted_at" IS NULL AND "id" = $3

The varchar(8) introduced in #558 can not fit the word completed so I will change it to varchar(10) to have on-demand queries operational again.

@javuto
Copy link
Collaborator Author

javuto commented Dec 27, 2024

Confirmed fix works on a fresh environment: #578

@javuto javuto closed this as completed Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working osctrl-tls osctrl-tls related changes queries On-demand queries related issues
Projects
None yet
Development

No branches or pull requests

1 participant