New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency for active nodes in API & UI #471

Open

peterbogdan opened this issue Aug 7, 2024 · 0 comments

Assignees

Labels

osctrl-api

Contributor

peterbogdan commented Aug 7, 2024 •

edited

Loading

Hello

I see there are some inconsistency in Active nodes when getting them using the API:

{api}/api/v1//nodes/{env}/active/

Looking at the code it is querying for the field updated_at: https://github.com/jmpsec/osctrl/blob/main/nodes/nodes.go#L241

Maybe we can use the helper function from here to have better results: https://github.com/jmpsec/osctrl/blob/main/nodes/utils.go#L9

The text was updated successfully, but these errors were encountered:

javuto self-assigned this

javuto added the osctrl-api label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment