Fix for broken animations with FF31 update #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't a fix. It just removes the feature and could have bad side effects to other properties... |
|
Try to implement something like #154 (comment) |
|
Changed fix according to #154 (comment). I haven't tested it yet. |
| @@ -41,6 +41,9 @@ | |||
| } | |||
| var index = 1 + name.substr(1).search(/[A-Z]/); | |||
| var prefix = name.substr(0, index).toLowerCase(); | |||
| if(prefix === '') { | |||
| return name; | |||
There was a problem hiding this comment.
This need to be:
return name.toLowerCase();
| @@ -14,7 +14,7 @@ | |||
| */ | |||
| var pfx = (function () { | |||
| var style = document.createElement('dummy').style, | |||
| prefixes = 'Webkit Moz O ms Khtml'.split(' '), | |||
| prefixes = ['webkit', 'moz', 'o', 'ms', 'khtml', ''], | |||
There was a problem hiding this comment.
Each entry need to start with an upper case letter...
|
Only noticed this thread after creating a pull request of my own. You're welcome to throw mine away. Cheers :) |
sokra
added a commit
that referenced
this pull request
Sep 12, 2014
Fix for broken animations with FF31 update fixes #162
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #154