Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm out of sync with latest code #187

Open
patorjk opened this issue Apr 2, 2016 · 0 comments
Open

npm out of sync with latest code #187

patorjk opened this issue Apr 2, 2016 · 0 comments

Comments

@patorjk
Copy link

patorjk commented Apr 2, 2016

I installed this library with npm and noticed the transitions between slides didn't work in Chrome or FireFox (but they did work in Safari - I was on a Mac when doing my testing). I did some digging and found this thread:

#154

In there the issue is fixed with this pull request:

omervk@5c1ee86

I checked the library I got from npm and it didn't have those updates. I looked at the code in this repo and it seems to have those updates. I added them in and now transitions between slides seem to work. Another side note, I don't see any slide transitions when I look at your official demo:

http://jmpressjs.github.io/jmpress.js/

It's version of the code seems to match what's in npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant