Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma API changes #148

Open
4 tasks
Edgarware opened this issue Oct 26, 2021 · 6 comments
Open
4 tasks

Gamma API changes #148

Edgarware opened this issue Oct 26, 2021 · 6 comments

Comments

@Edgarware
Copy link
Collaborator

Edgarware commented Oct 26, 2021

List of things that I know are 100% busted in the tests, will update as I find things
(updated for Gamma 4)

  • Statsheets 502 on bad ID
  • New endpoints & parameters
  • games/schedule is base64/gzip encoded now.... fixed?
  • 🦀streamdata is dead 🦀
@brendonakay
Copy link

I'd like to contribute to this project. Could I take on the Offseason/Chronicler item? I'm new and would need to ramp up on this project, so if it is time sensitive I will defer.

@Edgarware
Copy link
Collaborator Author

I'd like to contribute to this project. Could I take on the Offseason/Chronicler item? I'm new and would need to ramp up on this project, so if it is time sensitive I will defer.

Sure! I've got a draft pull request for it already for reference, but I'm not super happy with it right now.

@brendonakay
Copy link

@Edgarware I took a gander at your PR and it seems a little involved for me as a new-comer. Great work, by the way! Any suggestions for any of these other items? I'm also happy to help code review.

@jmaliksi
Copy link
Owner

jmaliksi commented Nov 3, 2021

@brendonakay I was going to define a new model for the new api.blaseball.com/bets/availableBets?day= endpoint sometime this week but if you want to take a gander at that, should be a good way to learn mike's design

@Edgarware what are we thinking as far as the stream events? should we pull in frostbird's thing or hold off until we have a better idea of TGB's plans?

@brendonakay
Copy link

This is excellent, thanks @jmaliksi! I will take a look at that this week.

@Edgarware
Copy link
Collaborator Author

@Edgarware what are we thinking as far as the stream events? should we pull in frostbird's thing or hold off until we have a better idea of TGB's plans?

@jmaliksi I'm fine bringing in frostbird's thing, I dont really anticipate them fixing the deltas before next Short Circuit and it'll be useful for people dealing with old data in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants