Use chronicler base class to consolidate implementations where supported #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edgarware
reviewed
May 27, 2021
Edgarware
reviewed
May 27, 2021
blaseball_mike/models/base.py
Outdated
| @classmethod | ||
| def load_history(cls, id_, order='desc', count=None): | ||
| entities = chronicler.get_versions(cls._entity_type, id_=id_, order=order, count=count) | ||
| return [cls(dict(e['data'], timestamp=e['validFrom'])) for e in entities] |
There was a problem hiding this comment.
I think if you use () instead of [] this will produce a generator, which is probably what we actually want
Edgarware
reviewed
May 27, 2021
blaseball_mike/models/team.py
Outdated
Comment on lines
44
to
48
| if getattr(self, "timestamp", None): | ||
| return [Player.load_one_at_time(x, self.timestamp) for x in self._lineup_ids] | ||
| return [Player.load_one(x, time=self.timestamp) for x in self._lineup_ids] | ||
| else: | ||
| players = Player.load(*self._lineup_ids) | ||
| return [players.get(id_) for id_ in self._lineup_ids] |
There was a problem hiding this comment.
Now that we can use the same load function for both, we dont need these if/else trees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.