Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @github/include-fragment-element from 5.2.0 to 5.3.1 #80

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 15, 2021

Bumps @github/include-fragment-element from 5.2.0 to 5.3.1.

Release notes

Sourced from @​github/include-fragment-element's releases.

v5.3.1

This release guarantees the order of events. The order will now always be:

  • loadstart
  • include-fragment-replace
  • include-fragment-replaced
  • load
  • loadend

This release also guarantees that during the loadstart dispatch, the <include-fragment> element will still exist and be connected to the DOM.

v5.3.0

This adds a new attribute: loading. The loading attribute is eager by default but can be set to lazy which will defer loading of the fragment until it is visible in the viewport. This is similar to <img loading=lazy>.

Commits
  • 5785cf3 5.3.1
  • f936aeb Merge pull request #65 from github/fix-guarantee-order-of-load-events
  • 2770e69 test: use setup/teardown to override setTimeout
  • fcd51f6 test: add assertion that elem is still connected during load event
  • 01b82f7 refactor: add code comments
  • af2bd3d refactor: add code comments
  • b6212f7 refactor: flatten Promise.resolve()
  • ecce92e refactor: be more explicit about task queueing
  • 6007ed4 refactor: drop useless Promise.resolve
  • 936abae fix: guarantee order of load events
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 15, 2021
@dependabot dependabot bot requested a review from jmalcic March 15, 2021 07:39
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/github/include-fragment-element-5.3.1 branch from bb5abc0 to af4f77b Compare March 15, 2021 10:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 653765804

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.175%

Totals Coverage Status
Change from base Build 653761852: 0.0%
Covered Lines: 150
Relevant Lines: 157

💛 - Coveralls

@jmalcic jmalcic enabled auto-merge March 15, 2021 10:19
@jmalcic jmalcic merged commit 0509782 into master Mar 15, 2021
@jmalcic jmalcic deleted the dependabot/npm_and_yarn/github/include-fragment-element-5.3.1 branch March 15, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants