Close Files streams using try-with-resources #840
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| .map(Path::toString) | ||
| .forEach(engine.classLoader::addClasspath); | ||
| try (Stream<Path> pathStream = | ||
| Files.walk(Paths.get(arg)).filter(matcher::matches)) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
@sonatype-lift ignoreall
There was a problem hiding this comment.
The ignoreall command is active on this PR, all the existing Lift issues are ignored.
|
@sonatype-lift ignoreall |
mattirn
force-pushed
the
stream-resouce-leak
branch
from
c7702f0
to
b4d4209
Compare
builtins/src/main/java/org/jline/builtins/SyntaxHighlighter.java
Outdated
Show resolved
Hide resolved
| (path, f) -> pathMatcher.matches(path)) | ||
| .forEach(syntaxFiles::add); | ||
| try (Stream<Path> pathStream = Files.find( | ||
| Paths.get(new File(parameter).getParent()), |
There was a problem hiding this comment.
PATH_TRAVERSAL_IN: This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
@sonatype-lift ignoreall
There was a problem hiding this comment.
The ignoreall command is active on this PR, all the existing Lift issues are ignored.
mattirn
force-pushed
the
stream-resouce-leak
branch
from
b4d4209
to
db8f59d
Compare
| (path, f) -> pathMatcher.matches(path)) | ||
| .forEach(p -> out.println(p.getFileName())); | ||
| try (Stream<Path> pathStream = Files.find( | ||
| Paths.get(new File(parameter).getParent()), |
There was a problem hiding this comment.
PATH_TRAVERSAL_IN: This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input
❗❗ 2 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| builtins/src/main/java/org/jline/builtins/Source.java | 51 |
| builtins/src/main/java/org/jline/builtins/Commands.java | 1682 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
mattirn
force-pushed
the
stream-resouce-leak
branch
from
db8f59d
to
a99551b
Compare
|
@mattirn I pushed a subsequent commit that replaces |
| (path, f) -> pathMatcher.matches(path)) | ||
| .findFirst() | ||
| .ifPresent(path -> syntaxFiles.add(0, path)); | ||
| try (Stream<Path> pathStream = Files.walk(Paths.get(new File(parameter).getParent()))) { |
There was a problem hiding this comment.
PATH_TRAVERSAL_IN: This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input
❗❗ 4 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| builtins/src/main/java/org/jline/builtins/Commands.java | 1681 |
| console/src/main/java/org/jline/console/impl/ConsoleEngineImpl.java | 241 |
| groovy/src/main/java/org/jline/script/GroovyCommand.java | 292 |
| builtins/src/main/java/org/jline/builtins/Commands.java | 1681 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
No description provided.