Support for out or err stream for the terminal (fixes #787) #788

gnodet · 2022-06-09T15:02:41Z

No description provided.

sonatype-lift · 2022-06-09T15:22:14Z

terminal/src/main/java/org/jline/terminal/impl/exec/ExecSupport.java

+            ProcessBuilder.Redirect input = stream == Stream.Input
+                                ? ProcessBuilder.Redirect.INHERIT
+                                : getRedirect(stream == Stream.Output ? FileDescriptor.out : FileDescriptor.err);
+            Process p = new ProcessBuilder(OSUtils.TTY_COMMAND).redirectInput(input).start();


COMMAND_INJECTION: This usage of java/lang/ProcessBuilder.([Ljava/lang/String;)V can be vulnerable to Command Injection

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-09T15:22:22Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/win/JansiWinSysTerminal.java

@@ -73,36 +89,39 @@ public static JansiWinSysTerminal createTerminal(String name, String type, boole
        if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
            throw new IOException("Failed to get console mode: " + getLastErrorMessage());


RESOURCE_LEAK: resource of type org.jline.terminal.impl.jansi.win.JansiWinConsoleWriter acquired by call to JansiWinConsoleWriter() at line 67 is not released after line 90.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-09T15:22:24Z

terminal/src/main/java/org/jline/terminal/impl/Diag.java

+            try {
+                NonBlockingInputStream is = NonBlocking.nonBlocking( name, pty.getSlaveInput());
+                NonBlockingReader reader = NonBlocking.nonBlocking( name, is, StandardCharsets.UTF_8);
+                ForkJoinTask<Integer> t = new ForkJoinPool(1).submit(() -> is.read(1) );


RESOURCE_LEAK: resource of type org.jline.utils.NonBlockingInputStreamImpl acquired by call to nonBlocking(...) at line 166 is not released after line 168.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-09T15:22:32Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/win/JansiWinSysTerminal.java

@@ -73,36 +89,39 @@ public static JansiWinSysTerminal createTerminal(String name, String type, boole
        if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
            throw new IOException("Failed to get console mode: " + getLastErrorMessage());
        }
-        JansiWinSysTerminal terminal = new JansiWinSysTerminal(writer, name, type, encoding, codepage, nativeSignals, signalHandler);
+        JansiWinSysTerminal terminal = new JansiWinSysTerminal(writer, name, type, encoding, codepage, nativeSignals,


RESOURCE_LEAK: resource of type org.jline.terminal.impl.jansi.win.JansiWinConsoleWriter acquired by call to JansiWinConsoleWriter() at line 81 is not released after line 92.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-09T15:22:36Z

terminal/src/main/java/org/jline/terminal/impl/Diag.java

+            Attributes attr = enterRawMode(pty);
+            try {
+                NonBlockingInputStream is = NonBlocking.nonBlocking( name, pty.getSlaveInput());
+                NonBlockingReader reader = NonBlocking.nonBlocking( name, is, StandardCharsets.UTF_8);


RESOURCE_LEAK: resource of type org.jline.utils.NonBlocking$NonBlockingInputStreamReader acquired by call to nonBlocking(...) at line 167 is not released after line 167.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-09T15:22:39Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/JansiSupportImpl.java

@@ -74,21 +74,21 @@ public static boolean isAtLeast(int major, int minor) {
    }

    @Override
-    public Pty current() throws IOException {
+    public Pty current(Stream consoleStream) throws IOException {
        String osName = System.getProperty("os.name");
        if (osName.startsWith("Linux")) {


NULL_DEREFERENCE: object osName last assigned on line 78 could be null and is dereferenced at line 79.

(at-me in a reply with help or ignore)

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-10T10:21:37Z

terminal/src/main/java/org/jline/terminal/impl/ExecSupport.java

+            ProcessBuilder.Redirect input = stream == Stream.Input
+                                ? ProcessBuilder.Redirect.INHERIT
+                                : getRedirect(stream == Stream.Output ? FileDescriptor.out : FileDescriptor.err);
+            Process p = new ProcessBuilder(OSUtils.TTY_COMMAND).redirectInput(input).start();


COMMAND_INJECTION: This usage of java/lang/ProcessBuilder.([Ljava/lang/String;)V can be vulnerable to Command Injection

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell Liftbot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell Liftbot to leave out all the findings from this PR and from the status bar in Github.

When talking to Liftbot, you need to refresh the page to see its response. Click here to get to know more about Liftbot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-10T10:21:41Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/JansiSupportImpl.java

+        return "jansi";
+    }
+
+    public Pty current( Stream consoleStream) throws IOException {
        String osName = System.getProperty("os.name");
        if (osName.startsWith("Linux")) {


NULL_DEREFERENCE: object osName last assigned on line 85 could be null and is dereferenced at line 86.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell Liftbot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell Liftbot to leave out all the findings from this PR and from the status bar in Github.

When talking to Liftbot, you need to refresh the page to see its response. Click here to get to know more about Liftbot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-10T10:21:50Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/win/JansiWinSysTerminal.java

@@ -73,36 +89,39 @@ public static JansiWinSysTerminal createTerminal(String name, String type, boole
        if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
            throw new IOException("Failed to get console mode: " + getLastErrorMessage());


RESOURCE_LEAK: resource of type org.jline.terminal.impl.jansi.win.JansiWinConsoleWriter acquired by call to JansiWinConsoleWriter() at line 67 is not released after line 90.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell Liftbot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell Liftbot to leave out all the findings from this PR and from the status bar in Github.

When talking to Liftbot, you need to refresh the page to see its response. Click here to get to know more about Liftbot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-10T10:21:56Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/win/JansiWinSysTerminal.java

@@ -73,36 +89,39 @@ public static JansiWinSysTerminal createTerminal(String name, String type, boole
        if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
            throw new IOException("Failed to get console mode: " + getLastErrorMessage());
        }
-        JansiWinSysTerminal terminal = new JansiWinSysTerminal(writer, name, type, encoding, codepage, nativeSignals, signalHandler);
+        JansiWinSysTerminal terminal = new JansiWinSysTerminal(writer, name, type, encoding, codepage, nativeSignals,


RESOURCE_LEAK: resource of type org.jline.terminal.impl.jansi.win.JansiWinConsoleWriter acquired by call to JansiWinConsoleWriter() at line 81 is not released after line 92.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell Liftbot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell Liftbot to leave out all the findings from this PR and from the status bar in Github.

When talking to Liftbot, you need to refresh the page to see its response. Click here to get to know more about Liftbot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-16T15:51:32Z

terminal-jna/src/main/java/org/jline/terminal/impl/jna/win/WindowsAnsiWriter.java

@@ -109,7 +109,7 @@ private void applyAttribute() throws IOException {
        if (underline) {
            attributes |= BACKGROUND_INTENSITY;


NarrowingCompoundAssignment: Compound assignments from int to short hide lossy casts

Suggested change

attributes |= BACKGROUND_INTENSITY;

attributes = (short) (attributes | BACKGROUND_INTENSITY);

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-16T15:51:38Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/win/JansiWinSysTerminal.java

            }
        }
        if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
            throw new IOException("Failed to get console mode: " + getLastErrorMessage());
        }
-        JansiWinSysTerminal terminal = new JansiWinSysTerminal(writer, name, type, encoding, codepage, nativeSignals, signalHandler);
+        JansiWinSysTerminal terminal = new JansiWinSysTerminal(writer, name, type, encoding, nativeSignals,


RESOURCE_LEAK: resource of type org.jline.terminal.impl.jansi.win.JansiWinConsoleWriter acquired by call to JansiWinConsoleWriter(...) at line 69 is not released after line 94.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-16T15:51:39Z

terminal/src/main/java/org/jline/terminal/impl/Diag.java

+                    sb.append("The terminal seems to work: ");
+                    sb.append("terminal ").append(terminal.getClass().getName());
+                    if (terminal instanceof AbstractPosixTerminal) {
+                        sb.append(" with pty ").append(((AbstractPosixTerminal) terminal).getPty().getClass().getName());


NULL_DEREFERENCE: object returned by terminal.getPty() could be null and is dereferenced at line 112.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-16T15:51:44Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/win/JansiWinSysTerminal.java

            } else {
                if (type == null) {
                    type = TYPE_WINDOWS;
                }
-                writer = new WindowsAnsiWriter(new BufferedWriter(new JansiWinConsoleWriter()));
+                writer = new WindowsAnsiWriter(new BufferedWriter(new JansiWinConsoleWriter(console)));
            }
        }
        if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
            throw new IOException("Failed to get console mode: " + getLastErrorMessage());


RESOURCE_LEAK: resource of type org.jline.terminal.impl.jansi.win.JansiWinConsoleWriter acquired by call to JansiWinConsoleWriter(...) at line 69 is not released after line 92.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T14:10:17Z

terminal/src/main/java/org/jline/terminal/impl/exec/ExecTerminalProvider.java

+            ProcessBuilder.Redirect input = stream == Stream.Input
+                                ? ProcessBuilder.Redirect.INHERIT
+                                : getRedirect(stream == Stream.Output ? FileDescriptor.out : FileDescriptor.err);
+            Process p = new ProcessBuilder(OSUtils.TTY_COMMAND).redirectInput(input).start();


COMMAND_INJECTION: This usage of java/lang/ProcessBuilder.([Ljava/lang/String;)V can be vulnerable to Command Injection

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T14:10:18Z

terminal/src/main/java/org/jline/terminal/impl/exec/ExecTerminalProvider.java

+
+    public boolean isPosixSystemStream(Stream stream) {
+        try {
+            Process p = new ProcessBuilder(OSUtils.TEST_COMMAND, "-t", Integer.toString(stream.ordinal()))


COMMAND_INJECTION: This usage of java/lang/ProcessBuilder.([Ljava/lang/String;)V can be vulnerable to Command Injection

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T14:10:20Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/win/JansiWinSysTerminal.java

            } else {
                if (type == null) {
                    type = TYPE_WINDOWS;
                }
-                writer = new WindowsAnsiWriter(new BufferedWriter(new JansiWinConsoleWriter()));
+                writer = new WindowsAnsiWriter(new BufferedWriter(newConsoleWriter(console)));
            }
        }
        if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
            throw new IOException("Failed to get console mode: " + getLastErrorMessage());


RESOURCE_LEAK: resource of type org.jline.terminal.impl.jansi.win.JansiWinConsoleWriter acquired by call to newConsoleWriter(...) at line 68 is not released after line 91.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T14:10:21Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/JansiTerminalProvider.java

NULL_DEREFERENCE: object osName last assigned on line 106 could be null and is dereferenced at line 107.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T14:10:24Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/win/JansiWinSysTerminal.java

            }
        }
        if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
            throw new IOException("Failed to get console mode: " + getLastErrorMessage());
        }
-        JansiWinSysTerminal terminal = new JansiWinSysTerminal(writer, name, type, encoding, codepage, nativeSignals, signalHandler);
+        JansiWinSysTerminal terminal = new JansiWinSysTerminal(writer, name, type, encoding, nativeSignals,


RESOURCE_LEAK: resource of type org.jline.terminal.impl.jansi.win.JansiWinConsoleWriter acquired by call to newConsoleWriter(...) at line 82 is not released after line 93.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-06-17T14:10:25Z

terminal-jansi/src/main/java/org/jline/terminal/impl/jansi/JansiTerminalProvider.java

+        return "jansi";
+    }
+
+    public Pty current(Stream consoleStream) throws IOException {
        String osName = System.getProperty("os.name");
        if (osName.startsWith("Linux")) {


NULL_DEREFERENCE: object osName last assigned on line 85 could be null and is dereferenced at line 86.

Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@sonatype-lift ignoreall

The ignoreall command is active on this PR, all the existing Lift issues are ignored.

Fix formatting

b26ab0a

gnodet changed the title ~~Support for out or err stream for the terminal~~ Support for out or err stream for the terminal (fixes #787) Jun 9, 2022

gnodet force-pushed the i787-sys-out-err branch from 1ac8296 to 56a2e72 Compare June 9, 2022 15:08

gnodet marked this pull request as draft June 9, 2022 15:17

sonatype-lift bot reviewed Jun 9, 2022

View reviewed changes

sonatype-lift bot reviewed Jun 10, 2022

View reviewed changes

gnodet marked this pull request as ready for review June 13, 2022 12:23

sonatype-lift bot reviewed Jun 16, 2022

View reviewed changes

sonatype-lift bot reviewed Jun 17, 2022

View reviewed changes

gnodet added 3 commits June 17, 2022 16:28

Move codepage support into the TerminalBuilder

d0abb73

The PATH environment variable is iterated in reverse order

208ab42

Support out and err streams, introduce a TerminalProvider

6c06191

gnodet force-pushed the i787-sys-out-err branch from 5ed24e8 to 6c06191 Compare June 17, 2022 15:14

gnodet added this to the 3.22.0 milestone Jan 16, 2023

gnodet merged commit d6e84da into jline:master Jan 16, 2023

dlmarion mentioned this pull request Jun 2, 2023

Shell output going to stderr rather than stdout w/ jline-3.22.0 apache/accumulo#3446

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for out or err stream for the terminal (fixes #787) #788

Support for out or err stream for the terminal (fixes #787) #788

gnodet commented Jun 9, 2022

sonatype-lift bot Jun 9, 2022

sonatype-lift bot Jun 9, 2022

sonatype-lift bot Jun 9, 2022

sonatype-lift bot Jun 9, 2022

sonatype-lift bot Jun 9, 2022

sonatype-lift bot Jun 9, 2022

sonatype-lift bot Jun 10, 2022

sonatype-lift bot Jun 10, 2022

sonatype-lift bot Jun 10, 2022

sonatype-lift bot Jun 10, 2022

sonatype-lift bot Jun 16, 2022

sonatype-lift bot Jun 16, 2022

sonatype-lift bot Jun 16, 2022

sonatype-lift bot Jun 16, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

sonatype-lift bot Jun 17, 2022

gnodet Jun 17, 2022

sonatype-lift bot Jun 17, 2022

		@@ -73,36 +89,39 @@ public static JansiWinSysTerminal createTerminal(String name, String type, boole
		if (Kernel32.GetConsoleMode(consoleIn, mode) == 0) {
		throw new IOException("Failed to get console mode: " + getLastErrorMessage());

		@@ -109,7 +109,7 @@ private void applyAttribute() throws IOException {
		if (underline) {
		attributes \|= BACKGROUND_INTENSITY;

	attributes \|= BACKGROUND_INTENSITY;
	attributes = (short) (attributes \| BACKGROUND_INTENSITY);

Support for out or err stream for the terminal (fixes #787) #788

Support for out or err stream for the terminal (fixes #787) #788

Conversation

gnodet commented Jun 9, 2022

sonatype-lift bot Jun 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment

gnodet Jun 17, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jun 17, 2022

Choose a reason for hiding this comment