-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot update PHPOffice/PhpSpreadsheet #617
Comments
@jlevers any news about this issue? Thank you. Best regards |
Just to follow up on our project fixing to version 1.25.2 has a cascade effect on some other libraries including maennchen/zipstream-php and psr/http-message causing them all to be downloaded. Any chance this can be fixed? Thanks. |
Any new about this one? Still stuck too because of this restriction. |
Just FYI I got round this by adding the following into my composer.json All working fine.
|
@stevenbrookes thank you for your workaround. I will do like you, hoping it will change directly in this library after. |
Sorry for the radio silence...if you upgrade to |
@jlevers great news I'll take a look at that. I saw you used saloon-sdk-generator to create the SDK etc. Can I ask why you used that library? We've been using openapi-generator for a while and we are looking for something that generates more modern and flexible code. We've looked at janephp (https://github.com/janephp/janephp) but not yet taken the plunge. I'd be interested in your thoughts. |
I went through a few different codegen systems before settling on this one.
I started writing my own Saloon generator from scratch, and then came across crescat-io/saloon-sdk-generator. At the time, it didn't have support for body schema/response/DTO generation, so I forked it and wrote that part. It looks like they've since added support for basic body schemas and DTOs, although I think that my fork is still ahead in terms of full OpenAPI spec compatibility. That said, I haven't maintained the Postman schema generation side of things in my fork, so I'm sure they're ahead of me on that. I should talk with them about merging my fork somehow. Hope that helps :) |
Thanks that's very helpful. I'll give both fork's a try. Does sound like it would be good to feedback to the original project - sometimes too much choice isn't a benefit! Oh and thanks again for this library - a real time saver. |
In your compser.json there's a dependency from PHPOffice/PhpSpreadsheet but it is fixed to a single version 1.25.2
So it's impossible to update this package even for minor version o bug fixes (actually phpspreadsheet is at version 1.29).
Are there any backward to change the composer.json with ^1.25.2 so the minimum version required is 1.25.2 but minor or fixes updates can be acceppted by composer update.
Thank you.
Best regards
The text was updated successfully, but these errors were encountered: