Skip to content

Commit

Permalink
Analyser Warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ObjColumnist committed Jul 9, 2013
1 parent 3caed85 commit ce6117f
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 20 deletions.
42 changes: 23 additions & 19 deletions Vendor/CocoaAsyncSocket/GCDAsyncSocket.m
Original file line number Diff line number Diff line change
Expand Up @@ -5835,25 +5835,29 @@ - (void)maybeStartTLS
#if TARGET_OS_IPHONE
{
GCDAsyncSpecialPacket *tlsPacket = (GCDAsyncSpecialPacket *)currentRead;
NSDictionary *tlsSettings = tlsPacket->tlsSettings;

NSNumber *value;

value = [tlsSettings objectForKey:(NSString *)kCFStreamSSLAllowsAnyRoot];
if (value && [value boolValue] == YES)
canUseSecureTransport = NO;

value = [tlsSettings objectForKey:(NSString *)kCFStreamSSLAllowsExpiredRoots];
if (value && [value boolValue] == YES)
canUseSecureTransport = NO;

value = [tlsSettings objectForKey:(NSString *)kCFStreamSSLValidatesCertificateChain];
if (value && [value boolValue] == NO)
canUseSecureTransport = NO;

value = [tlsSettings objectForKey:(NSString *)kCFStreamSSLAllowsExpiredCertificates];
if (value && [value boolValue] == YES)
canUseSecureTransport = NO;

if(tlsPacket)
{
NSDictionary *tlsSettings = tlsPacket->tlsSettings;

NSNumber *value = nil;

value = [tlsSettings objectForKey:(NSString *)kCFStreamSSLAllowsAnyRoot];
if (value && [value boolValue] == YES)
canUseSecureTransport = NO;

value = [tlsSettings objectForKey:(NSString *)kCFStreamSSLAllowsExpiredRoots];
if (value && [value boolValue] == YES)
canUseSecureTransport = NO;

value = [tlsSettings objectForKey:(NSString *)kCFStreamSSLValidatesCertificateChain];
if (value && [value boolValue] == NO)
canUseSecureTransport = NO;

value = [tlsSettings objectForKey:(NSString *)kCFStreamSSLAllowsExpiredCertificates];
if (value && [value boolValue] == YES)
canUseSecureTransport = NO;
}
}
#endif

Expand Down
5 changes: 4 additions & 1 deletion Vendor/CocoaLumberjack/DDAbstractDatabaseLogger.m
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,10 @@ - (void)createAndStartDeleteTimer

[self updateDeleteTimer];

dispatch_resume(deleteTimer);
if(deleteTimer != NULL)
{
dispatch_resume(deleteTimer);
}
}
}
}
Expand Down

0 comments on commit ce6117f

Please sign in to comment.