FileCmp crashes when using Julia 1.10-rc1

[ufechner7]

     Testing Running tests...
FileCmp.jl: Error During Test at /home/ufechner/.julia/packages/FileCmp/08oCB/test/runtests.jl:5
  Got exception outside of a @test
  MethodError: no method matching _memcmp(::Vector{UInt8}, ::Vector{UInt8}, ::Int64)
  
  Closest candidates are:
    _memcmp(::Union{Ptr{UInt8}, AbstractString}, ::Union{Ptr{UInt8}, AbstractString}, ::Int64)
     @ Base strings/string.jl:129
  
  Stacktrace:
    [1] filecmp(io1::IOStream, io2::IOStream, _bufsize::Int64; info::Bool, limit::Int64)
      @ FileCmp ~/.julia/packages/FileCmp/08oCB/src/FileCmp.jl:125
    [2] filecmp
      @ ~/.julia/packages/FileCmp/08oCB/src/FileCmp.jl:109 [inlined]
    [3] #4
      @ ~/.julia/packages/FileCmp/08oCB/src/FileCmp.jl:157 [inlined]
    [4] open(::FileCmp.var"#4#6"{IOStream, Bool, Int64, Int64}, ::String, ::Vararg{String}; kwargs::@Kwargs{})
      @ Base ./io.jl:396
    [5] open
      @ ./io.jl:393 [inlined]
    [6] #3
      @ ~/.julia/packages/FileCmp/08oCB/src/FileCmp.jl:156 [inlined]
    [7] open(::FileCmp.var"#3#5"{Bool, Int64, String, Int64}, ::String, ::Vararg{String}; kwargs::@Kwargs{})
      @ Base ./io.jl:396
    [8] open
      @ Base ./io.jl:393 [inlined]
    [9] #filecmp#2
      @ FileCmp ~/.julia/packages/FileCmp/08oCB/src/FileCmp.jl:155 [inlined]
   [10] filecmp
      @ FileCmp ~/.julia/packages/FileCmp/08oCB/src/FileCmp.jl:148 [inlined]
   [11] macro expansion
      @ ~/.julia/packages/FileCmp/08oCB/test/runtests.jl:30 [inlined]
   [12] macro expansion
      @ ~/packages/julias/julia-1.10/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
   [13] top-level scope
      @ ~/.julia/packages/FileCmp/08oCB/test/runtests.jl:6
   [14] include(fname::String)
      @ Base.MainInclude ./client.jl:489
   [15] top-level scope
      @ none:6
   [16] eval
      @ Core ./boot.jl:383 [inlined]
   [17] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:291
   [18] _start()
      @ Base ./client.jl:552
Test Summary: | Pass  Error  Total  Time
FileCmp.jl    |    4      1      5  0.9s
ERROR: LoadError: Some tests did not pass: 4 passed, 0 failed, 1 errored, 0 broken.
in expression starting at /home/ufechner/.julia/packages/FileCmp/08oCB/test/runtests.jl:5
ERROR: Package FileCmp errored during testing

Output of versioninfo():

julia> versioninfo()
Julia Version 1.10.0-rc1
Commit 5aaa9485436 (2023-11-03 07:44 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 32 × AMD Ryzen 9 7950X 16-Core Processor
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
  Threads: 1 on 32 virtual cores
Environment:
  LD_LIBRARY_PATH = /lib:/usr/lib:/usr/local/lib
``

[jlapeyre]

Thanks for the report!

[jlapeyre]

This bug is fixed in the main branch. 37a2adf

I'll try to make a release soon.

It looks like the JET test is not working and/or is very slow with Julia 1.10. I may need to disable this.

[jlapeyre]

There were additional problems with new versions of Julia and Aqua and JET, as well as three different ways to call Base._memcmp depending on the Julia version.

With commit: 6b6c14f this seems to be fixed. There are no allocations now. Performance is typically better (depending on parameters) But not always.