Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

success even if chart is not found #115

Closed
jlandowner opened this issue May 17, 2024 · 0 comments · Fixed by #136
Closed

success even if chart is not found #115

jlandowner opened this issue May 17, 2024 · 0 comments · Fixed by #136
Labels
bug Something isn't working

Comments

@jlandowner
Copy link
Owner

After #110 chartsnap can take a error output snapshot with success exitcode. But also it unintentionally takes a error snapshot that chart is not found.

It should take only helm's rendering output(including rendering error) and it should exit with errors excluding rendering error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix not showing error log when helm command failed jlandowner/helm-chartsnap
1 participant
@jlandowner