Handling of switch expressions and rule cases in Flow and NPECheck hint. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
jlahoda-jackpot
Aug 1, 2020
jlahoda
commented
Aug 1, 2020
| @@ -101,7 +101,8 @@ | |||
| import javax.lang.model.type.TypeMirror; | |||
| import org.netbeans.api.java.source.CompilationInfo; | |||
| import org.netbeans.api.java.source.CompilationInfo.CacheClearPolicy; | |||
| import org.netbeans.api.java.source.support.CancellableTreePathScanner; | |||
| import org.netbeans.api.java.source.support.CancellableTreeScanner; | |||
| import org.netbeans.modules.editor.java.TreeShims; | |||
jlahoda
commented
Aug 1, 2020
| } | ||
|
|
||
| public Boolean scan(TreePath path, ConstructorData p) { | ||
| TreePath oldPath = currentPath; |
jlahoda
commented
Aug 1, 2020
| if (TreeShims.SWITCH_EXPRESSION.equals(tree.getKind().name())) { | ||
| result = visitSwitchExpression(tree, p); | ||
| } else if (TreeShims.YIELD.equals(tree.getKind().name())) { | ||
| result = visitYield(tree, p); |
jlahoda
commented
Aug 1, 2020
| @@ -1172,37 +1207,63 @@ public Boolean visitBreak(BreakTree node, ConstructorData p) { | |||
|
|
|||
| Tree target = info.getTreeUtilities().getBreakContinueTargetTree(getCurrentPath()); | |||
|
|
|||
| resumeAfter(target, variable2State); | |||
| breakTo(target); | |||
jlahoda
commented
Aug 1, 2020
|
|
||
| breakTo(target); |
jlahoda
commented
Aug 1, 2020
| private void breakTo(Tree target) { | ||
| resumeAfter(target, variable2State); | ||
|
|
||
| variable2State = new HashMap< Element, State>(); |
jlahoda
commented
Aug 1, 2020
| variable2State = mergeOr(variable2State, origVariable2State); | ||
|
|
||
| if (ct.getExpression() == null) { | ||
| exhaustive = true; | ||
| } | ||
|
|
||
| scan(ct, null); | ||
|
|
||
| if (TreeShims.isRuleCase(ct)) { |
| private void breakTo(Tree target) { | ||
| resumeAfter(target, variable2State); | ||
|
|
||
| variable2State = new HashMap< Element, State>(); |
There was a problem hiding this comment.
Jackpot:
warning: Redundant type arguments in new expression (use diamond operator instead).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.