test - jdk/amber/string tapas #28

jlahoda · 2019-06-02T06:15:48Z

No description provided.

…literal.

jlahoda-jackpot · 2019-06-02T20:28:59Z

.../java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/TestBase.java

+        final Document doc = getDocument(testSourceFO);
+        final List<HighlightImpl> highlights = new ArrayList<HighlightImpl>();
+
+        JavaSource source = JavaSource.forFileObject(testSourceFO);


Jackpot:
warning: This anonymous inner class creation can be turned into a lambda expression.

jlahoda-jackpot · 2019-06-02T20:29:00Z

.../java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/TestBase.java

+        assertEquals(Arrays.asList(expected),
+                     highlights.stream()
+                               .map(h -> h.getHighlightTestData())
+                               .collect(Collectors.toList()));
    }



Jackpot:
warning: Can use functional operations

jlahoda-jackpot · 2019-06-02T20:29:01Z

.../java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/TestBase.java

+
+        FileObject srcRoot = FileUtil.toFileObject(testSource.getParentFile());
+        SourceUtilsTestUtil.prepareTest(srcRoot,FileUtil.toFileObject(testBuildTo), cache);
+


Jackpot:
warning: Redundant type arguments in new expression (use diamond operator instead).

jlahoda-jackpot · 2019-06-02T20:29:02Z

.../java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/TestBase.java

+                try {
+                    parameter.toPhase(Phase.UP_TO_DATE);
+
+                    ErrorDescriptionSetterImpl setter = new ErrorDescriptionSetterImpl();


Jackpot:
warning: Print Stack Trace

jlahoda-jackpot · 2019-06-02T20:29:03Z

.../java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/TestBase.java

+        final Document doc = getDocument(testSourceFO);
+        final List<HighlightImpl> highlights = new ArrayList<HighlightImpl>();
+
+        JavaSource source = JavaSource.forFileObject(testSourceFO);


Jackpot:
warning: Dereferencing possible null pointer

jlahoda-jackpot · 2019-06-02T20:29:05Z

...a.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/DetectorTest.java

@@ -411,6 +441,19 @@ protected boolean process(CompilationInfo info, Document doc) {
        });
    }



Jackpot:
warning: This anonymous inner class creation can be turned into a lambda expression.

jlahoda-jackpot · 2019-06-02T20:29:07Z

java/java.source.base/test/unit/src/org/netbeans/api/java/source/gen/LiteralTest.java

+            "                                   line\\n3\"\"\";\n" +
+            "}\n";
+        JavaSource testSource = JavaSource.forFileObject(FileUtil.toFileObject(testFile));
+        Task<WorkingCopy> task = new Task<WorkingCopy>() {


Jackpot:
warning: This anonymous inner class creation can be turned into a lambda expression.

jlahoda-jackpot · 2019-06-02T20:29:08Z

java/java.source.base/test/unit/src/org/netbeans/api/java/source/gen/LiteralTest.java

+            "                                   \"\"\";\n" +
+            "}\n";
+        JavaSource testSource = JavaSource.forFileObject(FileUtil.toFileObject(testFile));
+        Task<WorkingCopy> task = new Task<WorkingCopy>() {


Jackpot:
warning: This anonymous inner class creation can be turned into a lambda expression.

jlahoda-jackpot · 2019-06-02T20:29:09Z

java/java.editor/src/org/netbeans/modules/java/editor/semantic/SemanticHighlighter.java

@@ -60,13 +61,12 @@ protected boolean process(final CompilationInfo info, final Document doc) {

        public void setErrors(Document doc, List<ErrorDescription> errors, List<TreePathHandle> allUnusedImports) {}

-        public void setHighlights(final Document doc, final Collection<int[]> highlights) {
+        public void setHighlights(final Document doc, final Collection<Pair<int[], Coloring>> highlights) {
            SwingUtilities.invokeLater(new Runnable() {
                public void run() {


Jackpot:
warning: Can use functional operations

jlahoda-jackpot · 2019-06-02T20:29:10Z

java/java.editor/src/org/netbeans/modules/editor/java/TypingCompletion.java

@@ -31,6 +31,8 @@
 import org.netbeans.api.lexer.TokenHierarchy;
 import org.netbeans.api.lexer.TokenSequence;
 import org.netbeans.editor.BaseDocument;
+import org.netbeans.modules.editor.NbEditorUtilities;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:29:11Z

java/java.editor/src/org/netbeans/modules/editor/java/TypingCompletion.java

@@ -31,6 +31,8 @@
 import org.netbeans.api.lexer.TokenHierarchy;
 import org.netbeans.api.lexer.TokenSequence;
 import org.netbeans.editor.BaseDocument;
+import org.netbeans.modules.editor.NbEditorUtilities;
+import org.netbeans.modules.editor.indent.api.Indent;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:29:12Z

java/java.editor/src/org/netbeans/modules/editor/java/TypingCompletion.java

@@ -231,7 +240,7 @@ static int completeQuote(TypedTextInterceptor.MutableContext context) throws Bad
                        javaTS.move(context.getOffset() - 1);
                        if (javaTS.moveNext()) {
                            id = javaTS.token().id();
-                            if (id == JavaTokenId.STRING_LITERAL || id == JavaTokenId.CHAR_LITERAL) {
+                            if (id == JavaTokenId.STRING_LITERAL || id == JavaTokenId.CHAR_LITERAL || id == JavaTokenId.MULTILINE_STRING_LITERAL) {
                                context.setText("", 0); // NOI18N
                                return context.getOffset() + 1;


Jackpot:
warning: Thread Dump Stack

jlahoda-jackpot · 2019-06-02T20:29:12Z

java/java.editor/src/org/netbeans/modules/editor/java/TypingCompletion.java

+            if (context.getText().equals("\"") && context.getOffset() >= 2 && context.getDocument().getText(context.getOffset() - 2, 2).equals("\"\"")) {
+                context.setText("\"\n\"\"\"", 2);  // NOI18N
+                Thread.dumpStack();
+            } else {


Jackpot:
warning: Field STRING_AND_COMMENT_TOKENS can be final

jlahoda-jackpot · 2019-06-02T20:29:16Z

....editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java

@@ -80,6 +83,8 @@
 import org.netbeans.modules.parsing.spi.SchedulerEvent;
 import org.netbeans.modules.parsing.spi.TaskIndexingMode;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:29:17Z

java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/TokenList.java

@@ -240,6 +240,30 @@ public void run() {
        });
    }

+    public Token currentToken() {
+        Token[] res = new Token[1];
+        doc.render(new Runnable() {


Jackpot:
warning: This anonymous inner class creation can be turned into a lambda expression.

jlahoda-jackpot · 2019-06-02T20:29:18Z

java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToTextBlock.java

+import org.netbeans.api.java.source.CompilationInfo;
+import org.netbeans.spi.editor.hints.ErrorDescription;
+import org.netbeans.spi.editor.hints.Fix;
+import org.netbeans.spi.java.hints.ConstraintVariableType;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:29:19Z

java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToTextBlock.java

+import org.netbeans.spi.java.hints.Hint;
+import org.netbeans.spi.java.hints.HintContext;
+import org.netbeans.spi.java.hints.JavaFix;
+import org.netbeans.spi.java.hints.TriggerPattern;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:29:20Z

java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToTextBlock.java

+import com.sun.source.tree.Tree;
+import com.sun.source.tree.Tree.Kind;
+import com.sun.source.util.TreePath;
+import java.util.List;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:37:30Z

java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToTextBlock.java

+import com.sun.source.tree.Tree;
+import com.sun.source.tree.Tree.Kind;
+import com.sun.source.util.TreePath;
+import java.util.List;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:37:31Z

java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToTextBlock.java

+import org.netbeans.api.java.source.CompilationInfo;
+import org.netbeans.spi.editor.hints.ErrorDescription;
+import org.netbeans.spi.editor.hints.Fix;
+import org.netbeans.spi.java.hints.ConstraintVariableType;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:37:32Z

java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToTextBlock.java

+import org.netbeans.spi.java.hints.Hint;
+import org.netbeans.spi.java.hints.HintContext;
+import org.netbeans.spi.java.hints.JavaFix;
+import org.netbeans.spi.java.hints.TriggerPattern;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:37:33Z

java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/TokenList.java

@@ -240,6 +240,30 @@ public void run() {
        });
    }

+    public Token currentToken() {
+        Token[] res = new Token[1];
+        doc.render(new Runnable() {


Jackpot:
warning: This anonymous inner class creation can be turned into a lambda expression.

jlahoda-jackpot · 2019-06-02T20:37:35Z

....editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java

@@ -80,6 +83,8 @@
 import org.netbeans.modules.parsing.spi.SchedulerEvent;
 import org.netbeans.modules.parsing.spi.TaskIndexingMode;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:37:36Z

java/java.editor/src/org/netbeans/modules/editor/java/TypingCompletion.java

@@ -31,6 +31,8 @@
 import org.netbeans.api.lexer.TokenHierarchy;
 import org.netbeans.api.lexer.TokenSequence;
 import org.netbeans.editor.BaseDocument;
+import org.netbeans.modules.editor.NbEditorUtilities;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:37:37Z

java/java.editor/src/org/netbeans/modules/editor/java/TypingCompletion.java

@@ -31,6 +31,8 @@
 import org.netbeans.api.lexer.TokenHierarchy;
 import org.netbeans.api.lexer.TokenSequence;
 import org.netbeans.editor.BaseDocument;
+import org.netbeans.modules.editor.NbEditorUtilities;
+import org.netbeans.modules.editor.indent.api.Indent;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-06-02T20:37:38Z

java/java.editor/src/org/netbeans/modules/editor/java/TypingCompletion.java

@@ -231,7 +240,7 @@ static int completeQuote(TypedTextInterceptor.MutableContext context) throws Bad
                        javaTS.move(context.getOffset() - 1);
                        if (javaTS.moveNext()) {
                            id = javaTS.token().id();
-                            if (id == JavaTokenId.STRING_LITERAL || id == JavaTokenId.CHAR_LITERAL) {
+                            if (id == JavaTokenId.STRING_LITERAL || id == JavaTokenId.CHAR_LITERAL || id == JavaTokenId.MULTILINE_STRING_LITERAL) {
                                context.setText("", 0); // NOI18N
                                return context.getOffset() + 1;


Jackpot:
warning: Thread Dump Stack

jlahoda-jackpot · 2019-06-02T20:37:38Z

java/java.editor/src/org/netbeans/modules/editor/java/TypingCompletion.java

+            if (context.getText().equals("\"") && context.getOffset() >= 2 && context.getDocument().getText(context.getOffset() - 2, 2).equals("\"\"")) {
+                context.setText("\"\n\"\"\"", 2);  // NOI18N
+                Thread.dumpStack();
+            } else {


Jackpot:
warning: Field STRING_AND_COMMENT_TOKENS can be final

jlahoda-jackpot · 2019-06-02T20:37:39Z

java/java.editor/src/org/netbeans/modules/java/editor/semantic/SemanticHighlighter.java

@@ -60,13 +61,12 @@ protected boolean process(final CompilationInfo info, final Document doc) {

        public void setErrors(Document doc, List<ErrorDescription> errors, List<TreePathHandle> allUnusedImports) {}

-        public void setHighlights(final Document doc, final Collection<int[]> highlights) {
+        public void setHighlights(final Document doc, final Collection<Pair<int[], Coloring>> highlights) {
            SwingUtilities.invokeLater(new Runnable() {
                public void run() {


Jackpot:
warning: Can use functional operations

jlahoda-jackpot · 2019-06-02T20:37:41Z

.../java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/TestBase.java

+        assertEquals(Arrays.asList(expected),
+                     highlights.stream()
+                               .map(h -> h.getHighlightTestData())
+                               .collect(Collectors.toList()));
    }



Jackpot:
warning: Can use functional operations

jlahoda-jackpot · 2019-06-02T20:37:42Z

.../java.editor.base/test/unit/src/org/netbeans/modules/java/editor/base/semantic/TestBase.java

+                try {
+                    parameter.toPhase(Phase.UP_TO_DATE);
+
+                    ErrorDescriptionSetterImpl setter = new ErrorDescriptionSetterImpl();


Jackpot:
warning: Print Stack Trace

The relevant stacktraces for the affected threads are saved below. As there is also a warning logged with a clear indication: WARNING [org.netbeans.modules.parsing.impl.TaskProcessor]: ParserManager.parse called in AWT event thread by: org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getPropertyName(MicronautJavaHyperlinkProvider.java:151) Stacktraces: "AWT-EventQueue-0" #24 prio=6 os_prio=0 cpu=69156.33ms elapsed=76496.39s tid=0x00007feca4122b90 nid=0x106e2a waiting on condition [0x00007fec9756e000] java.lang.Thread.State: WAITING (parking) at jdk.internal.misc.Unsafe.park([email protected]/Native Method) - parking to wait for <0x00000006d7905fd0> (a java.util.concurrent.locks.ReentrantLock$FairSync) at java.util.concurrent.locks.LockSupport.park([email protected]/LockSupport.java:211) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire([email protected]/AbstractQueuedSynchronizer.java:715) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire([email protected]/AbstractQueuedSynchronizer.java:938) at java.util.concurrent.locks.ReentrantLock$Sync.lock([email protected]/ReentrantLock.java:153) at java.util.concurrent.locks.ReentrantLock.lock([email protected]/ReentrantLock.java:322) at org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:170) at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:83) at org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:454) at org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:425) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getPropertyName(MicronautJavaHyperlinkProvider.java:151) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.resolve(MicronautJavaHyperlinkProvider.java:122) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getHyperlinkSpan(MicronautJavaHyperlinkProvider.java:85) "Editor Parsing Loop (14-c4f2d87113e1a2d2d4e21e8952e1f99612d5b3fd)" #28 daemon prio=1 os_prio=0 cpu=65769.71ms elapsed=76494.46s tid=0x00007feca4401250 nid=0x106e35 in Object.wait() [0x00007fec957fe000] java.lang.Thread.State: WAITING (on object monitor) at java.lang.Object.wait([email protected]/Native Method) - waiting on <no object reference available> at java.lang.Object.wait([email protected]/Object.java:338) at org.netbeans.modules.parsing.impl.TaskProcessor$CurrentRequestReference.setCurrentTask(TaskProcessor.java:1128) - locked <0x00000006d75591d8> (a org.netbeans.modules.parsing.impl.TaskProcessor$CurrentRequestReference$CRRLock) at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.run(TaskProcessor.java:842) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279) at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.execute(TaskProcessor.java:702) at org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:663) "Module-Actions" apache#163 daemon prio=1 os_prio=0 cpu=2546.95ms elapsed=253.00s tid=0x00007fec806c9c90 nid=0x1abee2 in Object.wait() [0x00007fec951fa000] java.lang.Thread.State: WAITING (on object monitor) at java.lang.Object.wait([email protected]/Native Method) - waiting on <no object reference available> at java.lang.Object.wait([email protected]/Object.java:338) at javax.swing.text.AbstractDocument.writeLock([email protected]/AbstractDocument.java:1378) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) at org.netbeans.editor.BaseDocument.extWriteLock(BaseDocument.java:1696) at org.netbeans.editor.BaseDocument.atomicLockImpl(BaseDocument.java:1744) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) at org.netbeans.editor.GuardedDocument.runAtomicAsUser(GuardedDocument.java:329) at org.netbeans.modules.editor.lib.BeforeSaveTasks$TaskRunnable.run(BeforeSaveTasks.java:131) at org.netbeans.modules.editor.lib.TrailingWhitespaceRemove.runLocked(TrailingWhitespaceRemove.java:77)

jlahoda added 8 commits April 23, 2018 05:14

Sketch of raw string literals in lexer.

1d019a1

Sketch of background coloring for strip-indent regions of raw-string-…

c190cec

…literal.

Merging master into the raw-string-literals branch

05ab2e0

Merging master into the jdk/amber/raw-string-literal branch

38cd491

Updating to text blocks.

4ced4f2

Adding initial support for converting Strings to TextBlocks.

418f7aa

Progress on indenting text blocks.

1e71abf

Typing completion for text blocks.

6d54032

jlahoda-jackpot reviewed Jun 2, 2019

View reviewed changes

jlahoda added 3 commits June 6, 2019 06:28

Merge branch 'master' into jdk/amber/string-tapas

8361443

Fixing bugs in the Convert to Text Blocks hint.

4c3f57e

Merging master branch into jdk/amber/string-tapas

d53ac3d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test - jdk/amber/string tapas #28

test - jdk/amber/string tapas #28

jlahoda commented Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019

jlahoda-jackpot Jun 2, 2019


		FileObject srcRoot = FileUtil.toFileObject(testSource.getParentFile());
		SourceUtilsTestUtil.prepareTest(srcRoot,FileUtil.toFileObject(testBuildTo), cache);

		@@ -411,6 +441,19 @@ protected boolean process(CompilationInfo info, Document doc) {
		});
		}

		@@ -80,6 +83,8 @@
		import org.netbeans.modules.parsing.spi.SchedulerEvent;
		import org.netbeans.modules.parsing.spi.TaskIndexingMode;

test - jdk/amber/string tapas #28

Are you sure you want to change the base?

test - jdk/amber/string tapas #28

Conversation

jlahoda commented Jun 2, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment