Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time_format preference #231

Open
jkuester opened this issue Mar 23, 2024 · 6 comments
Open

Remove time_format preference #231

jkuester opened this issue Mar 23, 2024 · 6 comments
Milestone

Comments

@jkuester
Copy link
Owner

Unless someone has a really good use-case as to why they need Unlauncher to not always just follow the system time settings, I think we should just remove this preference that the associated logic.

To be clear, Unlauncher clocks should still support 12/24hr times, but they can always just follow the system settings. We don't need an extra preference to track this.

@jkuester jkuester added this to the 3.0.0 milestone Mar 23, 2024
@khwolf
Copy link

khwolf commented Mar 24, 2024

Actually i like the binary 12h clock (one bit less to compute in my head), yet with a digital clock i prefer 24h.

@elSolus
Copy link

elSolus commented Apr 7, 2024

Binary clock is good. How many good launchers provide this these days anyway?
Keep it please.
None, digital, analogue, binary all are fine.

@jkuester
Copy link
Owner Author

👍 Sorry, just to be clear, this issue is not about removing the clock itself or any of the variants (digital, analogue, binary, etc). Right now Unlauncher maintains a preference value which determines if the clock should display the time in the 12 hour format or the 24 hour format. I am considering removing this preference from Unlauncher since it could be considered redundant since Android, itself, already has a preference the user can set for this (and Unlauncher supports reading that preference to set the clock format...).

@elSolus
Copy link

elSolus commented Apr 13, 2024

Oh, yeah, sorry read it wrong. I am with you on this one. No redundancy needed.

@khwolf
Copy link

khwolf commented Apr 13, 2024

Exept for example like me who prefers the binary clock in 12h mode, but the "system clock" e.g in the top bar in 24h mode...

Another way to reach it would be to offer 4-bit and 5-bit digital clocks. The only other clock that (could) be affected would be the analog clock. Anyone wants a 24h analog clock? ;-)

@gitwah
Copy link

gitwah commented Jul 9, 2024

On that note I'd like to add that the date underneath the home screen clock is following the American date convention (e.g.: Tue, July 9.) despite my system preference being D-M-Y (e.g.: Tue, 9. July),. Could this be changed to just follow system preference? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants